From: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Date: Wed, 16 Jan 2013 14:36:56 +0000 (+0100)
Subject: mtd: uclinux: add a comment about why uclinux_ram_map must not be static
X-Git-Tag: v3.9-rc1~18^2~26
X-Git-Url: http://pileus.org/git/?a=commitdiff_plain;h=44fe63fc0fcbfef65b5a8c015abb4dbbbcc90f23;p=~andy%2Flinux

mtd: uclinux: add a comment about why uclinux_ram_map must not be static

I was (at least) the second person trying to fix a warning by sparse, so
document in the code why this is a bad idea and add an extern declaration to
make sparse happy.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Acked-by: Mike Frysinger <vapier@gentoo.org>
Acked-by: Greg Ungerer <gerg@uclinux.org>
Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
---

diff --git a/drivers/mtd/maps/uclinux.c b/drivers/mtd/maps/uclinux.c
index f56d0aa4404..c1af83db520 100644
--- a/drivers/mtd/maps/uclinux.c
+++ b/drivers/mtd/maps/uclinux.c
@@ -29,6 +29,12 @@
 #define MAP_NAME "ram"
 #endif
 
+/*
+ * Blackfin uses uclinux_ram_map during startup, so it must not be static.
+ * Provide a dummy declaration to make sparse happy.
+ */
+extern struct map_info uclinux_ram_map;
+
 struct map_info uclinux_ram_map = {
 	.name = MAP_NAME,
 	.size = 0,