eek, i've never seen a bug here, never been here and never fixed anything

Tue Jul 11 08:04:58 2000  Tim Janik  <timj@gtk.org>

        * gtk/gtktree.c (gtk_real_tree_select_child): eek, i've never seen
        a bug here, never been here and never fixed anything ;(
        (don't segfault if tree->root_tree is NULL, which happens prior
        to widget realization, but puke instead).

diff --git a/ChangeLog b/ChangeLog
index cce9c6d10c59732dc312fb2302322621a1d6d4df..c2eda145aedfd153c1bb50a37e7f7581e21de999 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,10 @@
+Tue Jul 11 08:04:58 2000  Tim Janik  <timj@gtk.org>
+
+        * gtk/gtktree.c (gtk_real_tree_select_child): eek, i've never seen
+        a bug here, never been here and never fixed anything ;(
+        (don't segfault if tree->root_tree is NULL, which happens prior
+        to widget realization, but puke instead).
+
 Tue Jul 11 06:38:42 2000  Tim Janik  <timj@gtk.org>
 
        * gtk/gtkrc.h: add xthickness and ythickness to GtkRcStyle and

diff --git a/ChangeLog.pre-2-0 b/ChangeLog.pre-2-0
index cce9c6d10c59732dc312fb2302322621a1d6d4df..c2eda145aedfd153c1bb50a37e7f7581e21de999 100644 (file)
--- a/ChangeLog.pre-2-0
+++ b/ChangeLog.pre-2-0
@@ -1,3 +1,10 @@
+Tue Jul 11 08:04:58 2000  Tim Janik  <timj@gtk.org>
+
+        * gtk/gtktree.c (gtk_real_tree_select_child): eek, i've never seen
+        a bug here, never been here and never fixed anything ;(
+        (don't segfault if tree->root_tree is NULL, which happens prior
+        to widget realization, but puke instead).
+
 Tue Jul 11 06:38:42 2000  Tim Janik  <timj@gtk.org>
 
        * gtk/gtkrc.h: add xthickness and ythickness to GtkRcStyle and

diff --git a/ChangeLog.pre-2-10 b/ChangeLog.pre-2-10
index cce9c6d10c59732dc312fb2302322621a1d6d4df..c2eda145aedfd153c1bb50a37e7f7581e21de999 100644 (file)
--- a/ChangeLog.pre-2-10
+++ b/ChangeLog.pre-2-10
@@ -1,3 +1,10 @@
+Tue Jul 11 08:04:58 2000  Tim Janik  <timj@gtk.org>
+
+        * gtk/gtktree.c (gtk_real_tree_select_child): eek, i've never seen
+        a bug here, never been here and never fixed anything ;(
+        (don't segfault if tree->root_tree is NULL, which happens prior
+        to widget realization, but puke instead).
+
 Tue Jul 11 06:38:42 2000  Tim Janik  <timj@gtk.org>
 
        * gtk/gtkrc.h: add xthickness and ythickness to GtkRcStyle and

diff --git a/ChangeLog.pre-2-2 b/ChangeLog.pre-2-2
index cce9c6d10c59732dc312fb2302322621a1d6d4df..c2eda145aedfd153c1bb50a37e7f7581e21de999 100644 (file)
--- a/ChangeLog.pre-2-2
+++ b/ChangeLog.pre-2-2
@@ -1,3 +1,10 @@
+Tue Jul 11 08:04:58 2000  Tim Janik  <timj@gtk.org>
+
+        * gtk/gtktree.c (gtk_real_tree_select_child): eek, i've never seen
+        a bug here, never been here and never fixed anything ;(
+        (don't segfault if tree->root_tree is NULL, which happens prior
+        to widget realization, but puke instead).
+
 Tue Jul 11 06:38:42 2000  Tim Janik  <timj@gtk.org>
 
        * gtk/gtkrc.h: add xthickness and ythickness to GtkRcStyle and

diff --git a/ChangeLog.pre-2-4 b/ChangeLog.pre-2-4
index cce9c6d10c59732dc312fb2302322621a1d6d4df..c2eda145aedfd153c1bb50a37e7f7581e21de999 100644 (file)
--- a/ChangeLog.pre-2-4
+++ b/ChangeLog.pre-2-4
@@ -1,3 +1,10 @@
+Tue Jul 11 08:04:58 2000  Tim Janik  <timj@gtk.org>
+
+        * gtk/gtktree.c (gtk_real_tree_select_child): eek, i've never seen
+        a bug here, never been here and never fixed anything ;(
+        (don't segfault if tree->root_tree is NULL, which happens prior
+        to widget realization, but puke instead).
+
 Tue Jul 11 06:38:42 2000  Tim Janik  <timj@gtk.org>
 
        * gtk/gtkrc.h: add xthickness and ythickness to GtkRcStyle and

diff --git a/ChangeLog.pre-2-6 b/ChangeLog.pre-2-6
index cce9c6d10c59732dc312fb2302322621a1d6d4df..c2eda145aedfd153c1bb50a37e7f7581e21de999 100644 (file)
--- a/ChangeLog.pre-2-6
+++ b/ChangeLog.pre-2-6
@@ -1,3 +1,10 @@
+Tue Jul 11 08:04:58 2000  Tim Janik  <timj@gtk.org>
+
+        * gtk/gtktree.c (gtk_real_tree_select_child): eek, i've never seen
+        a bug here, never been here and never fixed anything ;(
+        (don't segfault if tree->root_tree is NULL, which happens prior
+        to widget realization, but puke instead).
+
 Tue Jul 11 06:38:42 2000  Tim Janik  <timj@gtk.org>
 
        * gtk/gtkrc.h: add xthickness and ythickness to GtkRcStyle and

diff --git a/ChangeLog.pre-2-8 b/ChangeLog.pre-2-8
index cce9c6d10c59732dc312fb2302322621a1d6d4df..c2eda145aedfd153c1bb50a37e7f7581e21de999 100644 (file)
--- a/ChangeLog.pre-2-8
+++ b/ChangeLog.pre-2-8
@@ -1,3 +1,10 @@
+Tue Jul 11 08:04:58 2000  Tim Janik  <timj@gtk.org>
+
+        * gtk/gtktree.c (gtk_real_tree_select_child): eek, i've never seen
+        a bug here, never been here and never fixed anything ;(
+        (don't segfault if tree->root_tree is NULL, which happens prior
+        to widget realization, but puke instead).
+
 Tue Jul 11 06:38:42 2000  Tim Janik  <timj@gtk.org>
 
        * gtk/gtkrc.h: add xthickness and ythickness to GtkRcStyle and

diff --git a/gtk/gtktree.c b/gtk/gtktree.c
index 40c9fd79e2de604ca6af4968a4b454774be46806..a549e0e41a7dff6772b81e0df32cff43110e4ef1 100644 (file)
--- a/gtk/gtktree.c
+++ b/gtk/gtktree.c
@@ -1057,6 +1057,12 @@ gtk_real_tree_select_child (GtkTree   *tree,
   g_return_if_fail (GTK_IS_TREE (tree));
   g_return_if_fail (child != NULL);
   g_return_if_fail (GTK_IS_TREE_ITEM (child));
+
+  if (!tree->root_tree)
+    {
+      g_warning (G_STRLOC ": unable to select a child in a tree prior to realization");
+      return;
+    }
   
   root_selection = tree->root_tree->selection;