]> Pileus Git - ~andy/linux/commitdiff
dma: mv_xor: fix error checking of irq_of_parse_and_map()
authorThomas Petazzoni <thomas.petazzoni@free-electrons.com>
Thu, 22 Nov 2012 17:22:12 +0000 (18:22 +0100)
committerThomas Petazzoni <thomas.petazzoni@free-electrons.com>
Thu, 22 Nov 2012 17:22:12 +0000 (18:22 +0100)
The irq_of_parse_and_map() function returns 0 on failure, and does not
return an error code, so we fix the calling site of
irq_of_parse_and_map() in the mv_xor driver.

Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
drivers/dma/mv_xor.c

index 0d4c24e529f7737694b3a6a9ff91e344464b4c36..f2edd6a5536eda207cff139c7bf7c101e66cf13b 100644 (file)
@@ -1312,8 +1312,8 @@ static int __devinit mv_xor_probe(struct platform_device *pdev)
                                dma_cap_set(DMA_INTERRUPT, cap_mask);
 
                        irq = irq_of_parse_and_map(np, 0);
-                       if (irq < 0) {
-                               ret = irq;
+                       if (!irq) {
+                               ret = -ENODEV;
                                goto err_channel_add;
                        }