Fix a crash with icon themes

diff --git a/ChangeLog b/ChangeLog
index 11fae552ba38c548f7af7a580abfaffc510437eb..2fed51d6aff500092ab1f11de4ffbbe06ab5aa8e 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+2006-12-02  Matthias Clasen  <mclasen@redhat.com>
+
+       * gtk/gtkicontheme.c (insert_theme): Properly clean up
+       if an icon theme index file has no directories.  (#381236)
+
 2006-12-02  Dom Lachowicz <domlachowicz@gmail.com>
 
        * src/modules/engines/ms-windows/msw_style.c: Bug 351678 - Notebooks 

diff --git a/gtk/gtkicontheme.c b/gtk/gtkicontheme.c
index 52e2673a02187ccf9cfc1626f82e1bd3894454be..f04fa73a8f5b0e3c329944a7bb02fd69887a9b09 100644 (file)
--- a/gtk/gtkicontheme.c
+++ b/gtk/gtkicontheme.c
@@ -952,6 +952,8 @@ insert_theme (GtkIconTheme *icon_theme, const char *theme_name)
   if (!dirs)
     {
       g_warning ("Theme file for %s has no directories\n", theme_name);
+      priv->themes = g_list_remove (priv->themes, theme);
+      g_free (theme->name);
       g_free (theme->display_name);
       g_free (theme);
       g_key_file_free (theme_file);