]> Pileus Git - ~andy/linux/commitdiff
ath6kl: small cleanup in ath6kl_htc_pipe_rx_complete()
authorDan Carpenter <dan.carpenter@oracle.com>
Thu, 28 Feb 2013 04:45:47 +0000 (07:45 +0300)
committerJohn W. Linville <linville@tuxdriver.com>
Wed, 6 Mar 2013 21:25:48 +0000 (16:25 -0500)
It's harmless, but Smatch complains if we use "htc_hdr->eid" before
doing the bounds check.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
drivers/net/wireless/ath/ath6kl/htc_pipe.c

index 281390178e3d9d062bb7c8afbf8e06de6364f39e..9adb56741bc3fd13da6b0644fc52245dca7a3816 100644 (file)
@@ -988,8 +988,6 @@ static int ath6kl_htc_pipe_rx_complete(struct ath6kl *ar, struct sk_buff *skb,
 
        htc_hdr = (struct htc_frame_hdr *) netdata;
 
-       ep = &target->endpoint[htc_hdr->eid];
-
        if (htc_hdr->eid >= ENDPOINT_MAX) {
                ath6kl_dbg(ATH6KL_DBG_HTC,
                           "HTC Rx: invalid EndpointID=%d\n",
@@ -997,6 +995,7 @@ static int ath6kl_htc_pipe_rx_complete(struct ath6kl *ar, struct sk_buff *skb,
                status = -EINVAL;
                goto free_skb;
        }
+       ep = &target->endpoint[htc_hdr->eid];
 
        payload_len = le16_to_cpu(get_unaligned(&htc_hdr->payld_len));