]> Pileus Git - ~andy/linux/commitdiff
arch/arm/mach-omap2/clock.c: add missing clk_put
authorJulia Lawall <julia@diku.dk>
Mon, 4 Jul 2011 11:08:10 +0000 (04:08 -0700)
committerTony Lindgren <tony@atomide.com>
Mon, 4 Jul 2011 11:08:10 +0000 (04:08 -0700)
Add missing call to clk_put.

A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)

// <smpl>
@r exists@
expression e1,e2;
statement S;
@@

e1 = clk_get@p1(...);
... when != e1 = e2
    when != clk_put(e1)
    when any
if (...) { ... when != clk_put(e1)
               when != if (...) { ... clk_put(e1) ... }
* return@p3 ...;
 } else S
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Acked-by: Paul Walmsley <paul@pwsan.com>
Signed-off-by: Tony Lindgren <tony@atomide.com>
arch/arm/mach-omap2/clock.c

index 180299e4a838c05a2e2ce30afdfdbd49f6cd1524..bf9c36c7dffd55d073702597dd8e95f31544207d 100644 (file)
@@ -453,6 +453,7 @@ int __init omap2_clk_switch_mpurate_at_boot(const char *mpurate_ck_name)
        if (IS_ERR_VALUE(r)) {
                WARN(1, "clock: %s: unable to set MPU rate to %d: %d\n",
                     mpurate_ck->name, mpurate, r);
+               clk_put(mpurate_ck);
                return -EINVAL;
        }