]> Pileus Git - ~andy/linux/commitdiff
staging: serqt_usb2: Remove NULL check before kfree
authorIlia Mirkin <imirkin@alum.mit.edu>
Sun, 13 Mar 2011 05:29:09 +0000 (00:29 -0500)
committerGreg Kroah-Hartman <gregkh@suse.de>
Mon, 14 Mar 2011 18:57:35 +0000 (11:57 -0700)
This patch was generated by the following semantic patch:
// <smpl>
@@ expression E; @@
- if (E != NULL) { kfree(E); }
+ kfree(E);

@@ expression E; @@
- if (E != NULL) { kfree(E); E = NULL; }
+ kfree(E);
+ E = NULL;
// </smpl>

Signed-off-by: Ilia Mirkin <imirkin@alum.mit.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/staging/serqt_usb2/serqt_usb2.c

index 27841ef6a5689259e567b43259c8d14fb4747ee6..2be2d889d4438dca8a2258678f0a92ac081522b5 100644 (file)
@@ -1098,8 +1098,7 @@ static void qt_close(struct usb_serial_port *port)
 
        if (qt_port->write_urb) {
                /* if this urb had a transfer buffer already (old tx) free it */
-               if (qt_port->write_urb->transfer_buffer != NULL)
-                       kfree(qt_port->write_urb->transfer_buffer);
+               kfree(qt_port->write_urb->transfer_buffer);
                usb_free_urb(qt_port->write_urb);
        }