Cleanup the logic in expose event handler. Reviewed by Matthias Clasen,

* gtk/gtkcombobox.c (gtk_combo_box_expose_event): Cleanup the logic
  in expose event handler. Reviewed by Matthias Clasen, #406112

svn path=/trunk/; revision=17312

diff --git a/ChangeLog b/ChangeLog
index 52906a53e304314b82e46e3bffebed09375ab56e..a62cd1d84eaf25423541bd51e707f7a28890bab5 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+2007-02-16  Xan Lopez  <xan@gnome.org>
+
+       * gtk/gtkcombobox.c (gtk_combo_box_expose_event): Cleanup the logic
+       in expose event handler. Reviewed by Matthias Clasen, #406112
+
 2007-02-16  Matthias Clasen  <mclasen@redhat.com>
 
        * gtk/gtkmain.c: Run pre_parse_hook only once.  (#403139, Kjartan

diff --git a/gtk/gtkcombobox.c b/gtk/gtkcombobox.c
index 9fa730efd2d46397cda2f5d81a29029c6794ba13..f6fdb965d3cef439612fea12aa8637331b0af399 100644 (file)
--- a/gtk/gtkcombobox.c
+++ b/gtk/gtkcombobox.c
@@ -2276,19 +2276,14 @@ gtk_combo_box_expose_event (GtkWidget      *widget,
 {
   GtkComboBox *combo_box = GTK_COMBO_BOX (widget);
 
-  if (!combo_box->priv->tree_view)
-    {
-      gtk_container_propagate_expose (GTK_CONTAINER (widget),
-                                     combo_box->priv->button, event);
-    }
-  else
+  gtk_container_propagate_expose (GTK_CONTAINER (widget),
+                                 combo_box->priv->button, event);
+
+  if (combo_box->priv->tree_view &&
+      combo_box->priv->cell_view_frame)
     {
       gtk_container_propagate_expose (GTK_CONTAINER (widget),
-                                      combo_box->priv->button, event);
-
-      if (combo_box->priv->cell_view_frame)
-        gtk_container_propagate_expose (GTK_CONTAINER (widget),
-                                        combo_box->priv->cell_view_frame, event);
+                                     combo_box->priv->cell_view_frame, event);
     }
 
   gtk_container_propagate_expose (GTK_CONTAINER (widget),