]> Pileus Git - ~andy/linux/commitdiff
clocksource: armada-370-xp: Replace WARN_ON with BUG_ON
authorEzequiel Garcia <ezequiel.garcia@free-electrons.com>
Tue, 20 Aug 2013 15:45:52 +0000 (12:45 -0300)
committerDaniel Lezcano <daniel.lezcano@linaro.org>
Mon, 2 Sep 2013 19:44:13 +0000 (21:44 +0200)
If the clock fails to be obtained and the timer fails to be properly
registered, the kernel will freeze real soon. Instead, let's BUG()
where the actual problem is located.

Signed-off-by: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Acked-by: Jason Cooper <jason@lakedaemon.net>
Acked-by: Gregory CLEMENT <gregory.clement@free-electrons.com>
drivers/clocksource/time-armada-370-xp.c

index 86a354cca2154b8de98912f9f7d39cce8ea83340..6ca185df48c4e924c1737b5eba8b8d9082167d5f 100644 (file)
@@ -306,7 +306,7 @@ static void __init armada_370_timer_init(struct device_node *np)
 {
        struct clk *clk = of_clk_get(np, 0);
 
-       WARN_ON(IS_ERR(clk));
+       BUG_ON(IS_ERR(clk));
        timer_clk = clk_get_rate(clk) / TIMER_DIVIDER;
        timer25Mhz = false;