]> Pileus Git - ~andy/linux/commitdiff
drm/msm: Odd PTR_ERR usage
authorThomas Meyer <thomas@m3y3r.de>
Mon, 16 Sep 2013 21:19:54 +0000 (23:19 +0200)
committerRob Clark <robdclark@gmail.com>
Sat, 28 Sep 2013 12:53:26 +0000 (08:53 -0400)
The variable priv->kms is not initialized yet.

Found by "scripts/coccinelle/tests/odd_ptr_err.cocci".
PTR_ERR should access the value just tested by IS_ERR.

Signed-off-by: Thomas Meyer <thomas@m3y3r.de>
drivers/gpu/drm/msm/msm_drv.c

index 008d772384c7375859aeb51455f9993156ce9c05..fe03f9c26092f03dc46cd491c991b9c5cafc830b 100644 (file)
@@ -199,7 +199,7 @@ static int msm_load(struct drm_device *dev, unsigned long flags)
                 * imx drm driver on iMX5
                 */
                dev_err(dev->dev, "failed to load kms\n");
-               ret = PTR_ERR(priv->kms);
+               ret = PTR_ERR(kms);
                goto fail;
        }