]> Pileus Git - ~andy/linux/commitdiff
net: sis900: remove unnecessary pci_set_drvdata()
authorJingoo Han <jg1.han@samsung.com>
Mon, 9 Dec 2013 03:25:44 +0000 (12:25 +0900)
committerDavid S. Miller <davem@davemloft.net>
Mon, 9 Dec 2013 23:09:28 +0000 (18:09 -0500)
The driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.

Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/sis/sis900.c

index 975dc2d8e548c0942f58cac47550883528f6ebb8..ff57a46388eefed67c81b70dc67e8ddd6a698826 100644 (file)
@@ -576,7 +576,6 @@ err_unmap_tx:
 err_out_unmap:
        pci_iounmap(pci_dev, ioaddr);
 err_out_cleardev:
-       pci_set_drvdata(pci_dev, NULL);
        pci_release_regions(pci_dev);
  err_out:
        free_netdev(net_dev);
@@ -2427,7 +2426,6 @@ static void sis900_remove(struct pci_dev *pci_dev)
        pci_iounmap(pci_dev, sis_priv->ioaddr);
        free_netdev(net_dev);
        pci_release_regions(pci_dev);
-       pci_set_drvdata(pci_dev, NULL);
 }
 
 #ifdef CONFIG_PM