]> Pileus Git - ~andy/linux/commitdiff
sh_eth: use PIR_* bits
authorSergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Thu, 21 Mar 2013 10:37:54 +0000 (10:37 +0000)
committerDavid S. Miller <davem@davemloft.net>
Thu, 21 Mar 2013 21:20:54 +0000 (17:20 -0400)
sh_mdio_init() uses the bare numbers instead of the PHY interface bits, despite
these are declared in sh_eth.h as 'enum PIR_BIT'...

Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/renesas/sh_eth.c

index f632085e69b48301d26a863fd46c142e666eed44..a7b6c706236da63df162e024265967f590e6b911 100644 (file)
@@ -2254,10 +2254,10 @@ static int sh_mdio_init(struct net_device *ndev, int id,
        /* bitbang init */
        bitbang->addr = mdp->addr + mdp->reg_offset[PIR];
        bitbang->set_gate = pd->set_mdio_gate;
-       bitbang->mdi_msk = 0x08;
-       bitbang->mdo_msk = 0x04;
-       bitbang->mmd_msk = 0x02;/* MMD */
-       bitbang->mdc_msk = 0x01;
+       bitbang->mdi_msk = PIR_MDI;
+       bitbang->mdo_msk = PIR_MDO;
+       bitbang->mmd_msk = PIR_MMD;
+       bitbang->mdc_msk = PIR_MDC;
        bitbang->ctrl.ops = &bb_ops;
 
        /* MII controller setting */