]> Pileus Git - ~andy/linux/commitdiff
pnfs-obj: No longer needed to take an extra ref at add_device
authorBoaz Harrosh <bharrosh@panasas.com>
Fri, 17 Jun 2011 20:25:51 +0000 (16:25 -0400)
committerTrond Myklebust <Trond.Myklebust@netapp.com>
Sun, 19 Jun 2011 18:49:51 +0000 (14:49 -0400)
Andy's last device_cache patches, already take an extra
reference on the newly inserted device_id. So we can remove it
from obj-io.

Without this patch the device_ids are leaked.

Andy's patches are not in Linus tree yet. So I'm not sure if they are
scheduled for this Kernel or the next. This patch should be added as
part of these.

CC: Andy Adamson <andros@netapp.com>
Signed-off-by: Boaz Harrosh <bharrosh@panasas.com>
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
fs/nfs/objlayout/objio_osd.c

index 9cf208df1f2594b0ecbfc61e673e97c32844156a..eb4aafa9f521142d04137e6029655d80d4562f46 100644 (file)
@@ -108,7 +108,6 @@ _dev_list_add(const struct nfs_server *nfss,
                de = n;
        }
 
-       atomic_inc(&de->id_node.ref);
        return de;
 }