]> Pileus Git - ~andy/linux/commitdiff
hwmon: (ad7414) fix checkpatch issues
authorFrans Meulenbroeks <fransmeulenbroeks@gmail.com>
Sun, 8 Jan 2012 18:34:04 +0000 (19:34 +0100)
committerGuenter Roeck <guenter.roeck@ericsson.com>
Mon, 19 Mar 2012 01:26:35 +0000 (18:26 -0700)
fixed:
WARNING: simple_strtol is obsolete, use kstrtol instead
#133: FILE: ad7414.c:133:
+ long temp = simple_strtol(buf, NULL, 10);

Signed-off-by: Frans Meulenbroeks <fransmeulenbroeks@gmail.com>
Signed-off-by: Guenter Roeck <guenter.roeck@ericsson.com>
drivers/hwmon/ad7414.c

index df29a7fff9e7af8b8bf6a88a0f56ab714df10144..edbdb6d9a837f83630385ca8e35e3c2438aaf10d 100644 (file)
@@ -130,7 +130,11 @@ static ssize_t set_max_min(struct device *dev,
        struct ad7414_data *data = i2c_get_clientdata(client);
        int index = to_sensor_dev_attr(attr)->index;
        u8 reg = AD7414_REG_LIMIT[index];
-       long temp = simple_strtol(buf, NULL, 10);
+       long temp;
+       int ret = kstrtol(buf, 10, &temp);
+
+       if (ret < 0)
+               return ret;
 
        temp = SENSORS_LIMIT(temp, -40000, 85000);
        temp = (temp + (temp < 0 ? -500 : 500)) / 1000;