]> Pileus Git - ~andy/git/commitdiff
Merge branch 'maint'
authorJunio C Hamano <gitster@pobox.com>
Tue, 26 Oct 2010 22:04:05 +0000 (15:04 -0700)
committerJunio C Hamano <gitster@pobox.com>
Tue, 26 Oct 2010 22:04:05 +0000 (15:04 -0700)
* maint:
  Fix copy-pasted comments related to tree diff handling.

1  2 
diff.c

diff --combined diff.c
index 71efa8edd49fe1c80fb37a0468c68ef5ab0d2596,340d878f02b0daa3b26cf5eb3bf71bdda1437ce2..ba57bfab1748ea6a6401105421d298c236bc7ef3
--- 1/diff.c
--- 2/diff.c
+++ b/diff.c
@@@ -3271,17 -3271,12 +3271,17 @@@ int diff_opt_parse(struct diff_options 
        }
        else if ((argcount = short_opt('S', av, &optarg))) {
                options->pickaxe = optarg;
 +              options->pickaxe_opts |= DIFF_PICKAXE_KIND_S;
 +              return argcount;
 +      } else if ((argcount = short_opt('G', av, &optarg))) {
 +              options->pickaxe = optarg;
 +              options->pickaxe_opts |= DIFF_PICKAXE_KIND_G;
                return argcount;
        }
        else if (!strcmp(arg, "--pickaxe-all"))
 -              options->pickaxe_opts = DIFF_PICKAXE_ALL;
 +              options->pickaxe_opts |= DIFF_PICKAXE_ALL;
        else if (!strcmp(arg, "--pickaxe-regex"))
 -              options->pickaxe_opts = DIFF_PICKAXE_REGEX;
 +              options->pickaxe_opts |= DIFF_PICKAXE_REGEX;
        else if ((argcount = short_opt('O', av, &optarg))) {
                options->orderfile = optarg;
                return argcount;
@@@ -3532,7 -3527,7 +3532,7 @@@ static void diff_flush_stat(struct diff
  
        if ((DIFF_FILE_VALID(p->one) && S_ISDIR(p->one->mode)) ||
            (DIFF_FILE_VALID(p->two) && S_ISDIR(p->two->mode)))
-               return; /* no tree diffs in patch format */
+               return; /* no useful stat for tree diffs */
  
        run_diffstat(p, o, diffstat);
  }
@@@ -3545,7 -3540,7 +3545,7 @@@ static void diff_flush_checkdiff(struc
  
        if ((DIFF_FILE_VALID(p->one) && S_ISDIR(p->one->mode)) ||
            (DIFF_FILE_VALID(p->two) && S_ISDIR(p->two->mode)))
-               return; /* no tree diffs in patch format */
+               return; /* nothing to check in tree diffs */
  
        run_checkdiff(p, o);
  }
@@@ -4181,7 -4176,7 +4181,7 @@@ void diffcore_std(struct diff_options *
                        diffcore_merge_broken();
        }
        if (options->pickaxe)
 -              diffcore_pickaxe(options->pickaxe, options->pickaxe_opts);
 +              diffcore_pickaxe(options);
        if (options->orderfile)
                diffcore_order(options->orderfile);
        if (!options->found_follow)