]> Pileus Git - ~andy/git/commitdiff
tests: "cp -a" is a GNUism
authorBen Walton <bdwalton@gmail.com>
Mon, 8 Oct 2012 08:08:01 +0000 (09:08 +0100)
committerJunio C Hamano <gitster@pobox.com>
Mon, 8 Oct 2012 21:37:43 +0000 (14:37 -0700)
These tests just want a bit-for-bit identical copy; they do not need
even -H (there is no symbolic link involved) nor -p (there is no
funny permission or ownership issues involved).

Just use "cp -R" instead.

Signed-off-by: Ben Walton <bdwalton@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
t/t5400-send-pack.sh
t/t5550-http-fetch.sh
t/t5800-remote-helpers.sh

index 250c720c14602bdf21e6a7200437b13fe6feaca3..418f515ada50f1687a010a8f335f9363da5a0a3b 100755 (executable)
@@ -159,7 +159,7 @@ test_expect_success 'receive-pack runs auto-gc in remote repo' '
            git commit -a -m "Second commit" &&
            git repack
        ) &&
-       cp -a parent child &&
+       cp -R parent child &&
        (
            # Set the child to auto-pack if more than one pack exists
            cd child &&
index 16ef0419e9e4ea8d42aebd63c5bc5ec7f63d3732..80d20c876bbac0b00d388d511da555a29e827dbc 100755 (executable)
@@ -22,7 +22,7 @@ test_expect_success 'setup repository' '
 '
 
 test_expect_success 'create http-accessible bare repository with loose objects' '
-       cp -a .git "$HTTPD_DOCUMENT_ROOT_PATH/repo.git" &&
+       cp -R .git "$HTTPD_DOCUMENT_ROOT_PATH/repo.git" &&
        (cd "$HTTPD_DOCUMENT_ROOT_PATH/repo.git" &&
         git config core.bare true &&
         mkdir -p hooks &&
index 57023345100d3c04f9bfb1b2a701c53b6e55deed..e7dc668cef22719a778fb0447534466b88aaa245 100755 (executable)
@@ -76,7 +76,7 @@ test_expect_success 'pushing to local repo' '
 # git-remote-testgit, but is too slow to leave in for general use.
 : test_expect_success 'racily pushing to local repo' '
        test_when_finished "rm -rf server2 localclone2" &&
-       cp -a server server2 &&
+       cp -R server server2 &&
        git clone "testgit::${PWD}/server2" localclone2 &&
        (cd localclone2 &&
        echo content >>file &&