md: clear In_sync bit on devices added to an active array.

When we add a device to an active array it can be meaningful to set
the 'insync' flag.  This indicates that the device is in-sync with the
array except for locations recorded in the bitmap.
A bitmap-based recovery can then bring it completely in-sync.

Internally we move that flag to 'saved_raid_disk' but forgot to clear
In_sync like we do in add_new_disk.

So clear In_sync after moving its value to saved_raid_disk.

Reported-by: Andrei Warkentin <andreiw@vmware.com>
Signed-off-by: NeilBrown <neilb@suse.de>

diff --git a/drivers/md/md.c b/drivers/md/md.c
index 7a491771ff4dbd2d425745b63c921f4227166fd3..0ea34858637a4e55bea516976de5f7a9a4e6ca90 100644 (file)
--- a/drivers/md/md.c
+++ b/drivers/md/md.c
@@ -2722,6 +2722,7 @@ slot_store(struct md_rdev *rdev, const char *buf, size_t len)
                        rdev->saved_raid_disk = slot;
                else
                        rdev->saved_raid_disk = -1;
+               clear_bit(In_sync, &rdev->flags);
                err = rdev->mddev->pers->
                        hot_add_disk(rdev->mddev, rdev);
                if (err) {