]> Pileus Git - ~andy/linux/commitdiff
net: davinci_mdio: Fix typo mistake in calling runtime-pm api
authorVaibhav Hiremath <hvaibhav@ti.com>
Wed, 14 Nov 2012 09:07:54 +0000 (09:07 +0000)
committerDavid S. Miller <davem@davemloft.net>
Thu, 15 Nov 2012 03:09:06 +0000 (22:09 -0500)
By mistake (most likely a copy-paste), instead of pm_runtime_get_sync()
api, driver is calling pm_runtime_put_sync() api in resume callback
function. The bug was introduced by commit id (ae2c07aaf74:
davinci_mdio: runtime PM support).

Now, the reason why it didn't impact functionality is, the patch has
been tested on AM335x-EVM and BeagleBone platform while submitting;
and in case of AM335x the MDIO driver doesn't control the module
enable/disable part, which is handled by CPSW driver.

Signed-off-by: Vaibhav Hiremath <hvaibhav@ti.com>
Signed-off-by: Mugunthan V N <mugunthanvnm@ti.com>
Acked-by: Peter Korsgaard <jacmet@sunsite.dk>
Acked-by: Richard Cochran <richardcochran@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/ti/davinci_mdio.c

index 51a96dbee9accbae9dbe32e8eb3d81a367819307..ae74280c0b9f374ece40a0db4a9ac1c6a81a7ce8 100644 (file)
@@ -465,7 +465,7 @@ static int davinci_mdio_resume(struct device *dev)
        u32 ctrl;
 
        spin_lock(&data->lock);
-       pm_runtime_put_sync(data->dev);
+       pm_runtime_get_sync(data->dev);
 
        /* restart the scan state machine */
        ctrl = __raw_readl(&data->regs->control);