]> Pileus Git - ~andy/linux/commitdiff
xfs: prevent against ioend livelocks in xfs_file_fsync
authorChristoph Hellwig <hch@infradead.org>
Tue, 26 Jul 2011 15:07:11 +0000 (15:07 +0000)
committerAlex Elder <aelder@sgi.com>
Wed, 27 Jul 2011 03:06:39 +0000 (22:06 -0500)
We need to take some locks to prevent new ioends from coming in when we wait
for all existing ones to go away.  Up to Linux 3.0 that was done using the
i_mutex held by the VFS fsync code, but now that we are called without
it we need to take care of it ourselves.  Use the I/O lock instead of
i_mutex just like we do in other places.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Alex Elder <aelder@sgi.com>
fs/xfs/linux-2.6/xfs_file.c

index 825390e1c13850985c634fcbaec19c88ce2d6e46..7f7b42469ea7c9653903d0ffbe00769d40a168eb 100644 (file)
@@ -149,7 +149,9 @@ xfs_file_fsync(
 
        xfs_iflags_clear(ip, XFS_ITRUNCATED);
 
+       xfs_ilock(ip, XFS_IOLOCK_SHARED);
        xfs_ioend_wait(ip);
+       xfs_iunlock(ip, XFS_IOLOCK_SHARED);
 
        if (mp->m_flags & XFS_MOUNT_BARRIER) {
                /*