]> Pileus Git - ~andy/gtk/commitdiff
Don't check the same crossing mode twice
authorMatthias Clasen <mclasen@redhat.com>
Fri, 30 Nov 2012 03:06:18 +0000 (22:06 -0500)
committerMatthias Clasen <mclasen@redhat.com>
Fri, 30 Nov 2012 04:10:34 +0000 (23:10 -0500)
This was broken since commit b2aaa94 in 2008. Its commit message
clearly states that the intention was to check for GTK_GRAB,
GTK_UNGRAB and STATE_CHANGED. Lets do that, then.

This was found by Coverity.

gtk/gtkmenushell.c

index 50991792852d96ee0d3168786d1b7519b795e90c..942c721b9f3d5a112d07fe3a29a916c5d66c0c6c 100644 (file)
@@ -1107,7 +1107,7 @@ gtk_menu_shell_leave_notify (GtkWidget        *widget,
                              GdkEventCrossing *event)
 {
   if (event->mode == GDK_CROSSING_GTK_GRAB ||
-      event->mode == GDK_CROSSING_GTK_GRAB ||
+      event->mode == GDK_CROSSING_GTK_UNGRAB ||
       event->mode == GDK_CROSSING_STATE_CHANGED)
     return TRUE;