Improve print dialog

diff --git a/ChangeLog b/ChangeLog
index 3e2ab205be376645157d2162094f3e91c01cca7a..c7dad2d4f911870211e856c38fea6f7652ec5f84 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,9 @@
+2006-12-06  Matthias Clasen  <mclasen@redhat.com>
+
+       * gtk/gtkprintunixdialog.c (update_dialog_from_capabilities):
+       Update the sensitivity of the collate checkbutton more frequently,
+       proposed by Tim Waugh.
+
 2006-12-04  Matthias Clasen  <mclasen@redhat.com>
 
        * gtk/gtkmessagedialog.c (setup_type): Set a11y name and role

diff --git a/gtk/gtkprintunixdialog.c b/gtk/gtkprintunixdialog.c
index 6d83322b33ae38a8bf528d9fe890fd90cea065cb..712beac4e8d9c01a5345e255d7d5fa22ddfd45ad 100644 (file)
--- a/gtk/gtkprintunixdialog.c
+++ b/gtk/gtkprintunixdialog.c
@@ -1018,8 +1018,10 @@ update_dialog_from_capabilities (GtkPrintUnixDialog *dialog)
   GtkPrintCapabilities caps;
   GtkPrintUnixDialogPrivate *priv = dialog->priv;
   gboolean can_collate;
+  const gchar *copies;
 
-  can_collate = gtk_spin_button_get_value_as_int (GTK_SPIN_BUTTON (priv->copies_spin)) > 1;
+  copies = gtk_entry_get_text (GTK_ENTRY (priv->copies_spin));
+  can_collate = (*copies != '\0' && atoi (copies) > 1);
 
   caps = priv->manual_capabilities | priv->printer_capabilities;
 
@@ -1542,6 +1544,8 @@ create_main_page (GtkPrintUnixDialog *dialog)
   gtk_label_set_mnemonic_widget (GTK_LABEL (label), spinbutton);
   g_signal_connect_swapped (spinbutton, "value-changed", 
                            G_CALLBACK (update_dialog_from_capabilities), dialog);
+  g_signal_connect_swapped (spinbutton, "changed", 
+                           G_CALLBACK (update_dialog_from_capabilities), dialog);
   
   check = gtk_check_button_new_with_mnemonic (_("C_ollate"));
   priv->collate_check = check;