Emit the ::page-removed signal after removing the page. (#335238,

2006-03-22  Matthias Clasen  <mclasen@redhat.com>

	* gtk/gtknotebook.c (gtk_notebook_remove): Emit the ::page-removed
	signal after removing the page.  (#335238, Christian Persch)

diff --git a/ChangeLog b/ChangeLog
index 506a69138740d69f3d7f3e841d7aff0e506c7f05..730d65cd31de2d0144c20e9eda4e49c375ad8e85 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+2006-03-22  Matthias Clasen  <mclasen@redhat.com>
+
+       * gtk/gtknotebook.c (gtk_notebook_remove): Emit the ::page-removed
+       signal after removing the page.  (#335238, Christian Persch)
+
 2006-03-22  Carlos Garnacho  <carlosg@gnome.org>
 
        * gtk/gtkexpander.c: Make it to expand when hovering during DnD

diff --git a/ChangeLog.pre-2-10 b/ChangeLog.pre-2-10
index 506a69138740d69f3d7f3e841d7aff0e506c7f05..730d65cd31de2d0144c20e9eda4e49c375ad8e85 100644 (file)
--- a/ChangeLog.pre-2-10
+++ b/ChangeLog.pre-2-10
@@ -1,3 +1,8 @@
+2006-03-22  Matthias Clasen  <mclasen@redhat.com>
+
+       * gtk/gtknotebook.c (gtk_notebook_remove): Emit the ::page-removed
+       signal after removing the page.  (#335238, Christian Persch)
+
 2006-03-22  Carlos Garnacho  <carlosg@gnome.org>
 
        * gtk/gtkexpander.c: Make it to expand when hovering during DnD

diff --git a/gtk/gtknotebook.c b/gtk/gtknotebook.c
index b0017891f1ecef806cc9b062b569e74ea5354b82..cdbc2843caf48693d29fa5f5b74ae09f4817d282 100644 (file)
--- a/gtk/gtknotebook.c
+++ b/gtk/gtknotebook.c
@@ -855,7 +855,7 @@ gtk_notebook_class_init (GtkNotebookClass *class)
    * @page_num: the @child page number
    *
    * the ::page-removed signal is emitted in the notebook
-   * right before a page is removed from the notebook.
+   * right after a page is removed from the notebook.
    *
    * Since: 2.10
    **/
@@ -869,7 +869,7 @@ gtk_notebook_class_init (GtkNotebookClass *class)
                  GTK_TYPE_WIDGET,
                  G_TYPE_UINT);
   /**
-   * GtkNotebook::page-attached:
+   * GtkNotebook::page-added:
    * @notebook: the #GtkNotebook
    * @child: the child #GtkWidget affected
    * @page_num: the new page number for @child
@@ -3299,13 +3299,17 @@ gtk_notebook_remove (GtkContainer *container,
       children = children->next;
     }
 
+  g_object_ref (widget);
+
+  gtk_notebook_real_remove (notebook, children);
+
   g_signal_emit (notebook,
                 notebook_signals[PAGE_REMOVED],
                 0,
                 widget,
                 page_num);
-
-  gtk_notebook_real_remove (notebook, children);
+  
+  g_object_unref (widget);
 }
 
 static gboolean