]> Pileus Git - ~andy/linux/commitdiff
ARM: OMAP2+: gpmc: Move legacy GPMC width setting
authorEzequiel Garcia <ezequiel.garcia@free-electrons.com>
Mon, 28 Oct 2013 00:51:48 +0000 (21:51 -0300)
committerTony Lindgren <tony@atomide.com>
Wed, 8 Jan 2014 17:49:47 +0000 (09:49 -0800)
After the introduction of gpmc_set_legacy(), move the GPMC width setting
to be done inside it. Currently, in the DT probed case, this is (wrongly)
done twice: first at gpmc_read_settings_dt(), and then based in the
NAND width setting.
Fix this and use only the value obtained from the DT.

Signed-off-by: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
Signed-off-by: Tony Lindgren <tony@atomide.com>
arch/arm/mach-omap2/gpmc-nand.c

index 9dd40e70aca38c77df556d307cf5554300fa5c73..174caecc3186cbe6d25cb998be40a32478042484 100644 (file)
@@ -74,6 +74,11 @@ static void gpmc_set_legacy(struct omap_nand_platform_data *gpmc_nand_data,
                s->wait_on_read = true;
                s->wait_on_write = true;
        }
+
+       if (gpmc_nand_data->devsize == NAND_BUSWIDTH_16)
+               s->device_width = GPMC_DEVWIDTH_16BIT;
+       else
+               s->device_width = GPMC_DEVWIDTH_8BIT;
 }
 
 int gpmc_nand_init(struct omap_nand_platform_data *gpmc_nand_data,
@@ -118,11 +123,6 @@ int gpmc_nand_init(struct omap_nand_platform_data *gpmc_nand_data,
 
        s.device_nand = true;
 
-       if (gpmc_nand_data->devsize == NAND_BUSWIDTH_16)
-               s.device_width = GPMC_DEVWIDTH_16BIT;
-       else
-               s.device_width = GPMC_DEVWIDTH_8BIT;
-
        err = gpmc_cs_program_settings(gpmc_nand_data->cs, &s);
        if (err < 0)
                goto out_free_cs;