]> Pileus Git - ~andy/linux/commitdiff
[PATCH] p54: Make filter configuration atomic
authorMichael Wu <flamingice@sourmilk.net>
Sun, 14 Oct 2007 00:35:05 +0000 (20:35 -0400)
committerJohn W. Linville <linville@tuxdriver.com>
Thu, 18 Oct 2007 19:44:42 +0000 (15:44 -0400)
p54_set_filter is now called from configure_filter, which is not
allowed to sleep. The filter configuration packet allocation should be
atomic now.

Thanks to Dmitry Torokhov <dtor@insightbb.com> for reporting this bug.

Signed-off-by: Michael Wu <flamingice@sourmilk.net>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
drivers/net/wireless/p54common.c

index 2c63cf0ad2cdb3cfe11936e40147fd89b390f0da..1437db0cf4b271372d1a96df5164d74725169919 100644 (file)
@@ -577,7 +577,7 @@ static int p54_set_filter(struct ieee80211_hw *dev, u16 filter_type,
        struct p54_tx_control_filter *filter;
 
        hdr = kzalloc(sizeof(*hdr) + sizeof(*filter) +
-                     priv->tx_hdr_len, GFP_KERNEL);
+                     priv->tx_hdr_len, GFP_ATOMIC);
        if (!hdr)
                return -ENOMEM;