]> Pileus Git - ~andy/linux/commitdiff
Bluetooth: hci_conn_auto_accept() doesn't need locking
authorGustavo F. Padovan <padovan@profusion.mobi>
Fri, 17 Jun 2011 15:58:41 +0000 (12:58 -0300)
committerGustavo F. Padovan <padovan@profusion.mobi>
Sun, 18 Dec 2011 19:07:55 +0000 (17:07 -0200)
It doesn't really touch any sensitive information about hdev. So no need
to lock here.

Acked-by: Marcel Holtmann <marcel@holtmann.org>
Signed-off-by: Gustavo F. Padovan <padovan@profusion.mobi>
net/bluetooth/hci_conn.c

index 7d88a6142092248fa4a7d90f14c07b339f340af6..e6d8a220b5d94e304f37be00b344e0a5c79e70e7 100644 (file)
@@ -362,12 +362,8 @@ static void hci_conn_auto_accept(unsigned long arg)
        struct hci_conn *conn = (void *) arg;
        struct hci_dev *hdev = conn->hdev;
 
-       hci_dev_lock(hdev);
-
        hci_send_cmd(hdev, HCI_OP_USER_CONFIRM_REPLY, sizeof(conn->dst),
                                                                &conn->dst);
-
-       hci_dev_unlock(hdev);
 }
 
 struct hci_conn *hci_conn_add(struct hci_dev *hdev, int type, bdaddr_t *dst)