]> Pileus Git - ~andy/linux/commitdiff
dell-laptop - using buffer without mutex_lock
authorJose Alonso <joalonsof@gmail.com>
Sun, 10 Jul 2011 18:46:51 +0000 (15:46 -0300)
committerMatthew Garrett <mjg@redhat.com>
Mon, 11 Jul 2011 13:52:31 +0000 (09:52 -0400)
Using buffer->output[1] without mutex_lock()

Signed-off-by: Jose Alonso <joalonsof@gmail.com>
Signed-off-by: Matthew Garrett <mjg@redhat.com>
drivers/platform/x86/dell-laptop.c

index 04c34f1a265ce21ecf34e452bfb50d057f0962db..e39ab1d3ed878b6044a391db4be16b58224da0d2 100644 (file)
@@ -540,11 +540,11 @@ static int dell_get_intensity(struct backlight_device *bd)
        else
                dell_send_request(buffer, 0, 1);
 
+       ret = buffer->output[1];
+
 out:
        release_buffer();
-       if (ret)
-               return ret;
-       return buffer->output[1];
+       return ret;
 }
 
 static const struct backlight_ops dell_ops = {