]> Pileus Git - ~andy/linux/commitdiff
drivers/usb/core: using strlcpy instead of strncpy
authorChen Gang <gang.chen@asianux.com>
Sat, 2 Feb 2013 07:57:53 +0000 (15:57 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 6 Feb 2013 19:38:13 +0000 (11:38 -0800)
  for NUL terminated string, better notice '\0' in the end.

Signed-off-by: Chen Gang <gang.chen@asianux.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/core/devio.c

index b78fbe222b72c2e3bc662973e9f9f08941ce2628..4a863fdbdccd048782a084ded6468c9672524c86 100644 (file)
@@ -40,6 +40,7 @@
 #include <linux/signal.h>
 #include <linux/poll.h>
 #include <linux/module.h>
+#include <linux/string.h>
 #include <linux/usb.h>
 #include <linux/usbdevice_fs.h>
 #include <linux/usb/hcd.h>     /* for usbcore internals */
@@ -1077,7 +1078,7 @@ static int proc_getdriver(struct dev_state *ps, void __user *arg)
        if (!intf || !intf->dev.driver)
                ret = -ENODATA;
        else {
-               strncpy(gd.driver, intf->dev.driver->name,
+               strlcpy(gd.driver, intf->dev.driver->name,
                                sizeof(gd.driver));
                ret = (copy_to_user(arg, &gd, sizeof(gd)) ? -EFAULT : 0);
        }