Don't call GetWindowLong for GWL_EXSTYLE, the extended window style wasn't

2002-10-28  Tor Lillqvist  <tml@iki.fi>

	* gdk/win32/gdkwindow-win32.c (gdk_window_set_decorations,
	gdk_window_set_functions): Don't call GetWindowLong for
	GWL_EXSTYLE, the extended window style wasn't used or
	changed. After setting the window style with SetWindowLong, call
	SetWindowPos with the SWP_FRAMECHANGED flag for the window to
	actually be updated, as Platform SDK docs say one should. (#95812,
	huzheng)

diff --git a/ChangeLog b/ChangeLog
index 8d19800e3ce38f047c04a385ad95dbe76b27436e..0baf157a884b2383449b23116f4470229d63b82a 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,13 @@
+2002-10-28  Tor Lillqvist  <tml@iki.fi>
+
+       * gdk/win32/gdkwindow-win32.c (gdk_window_set_decorations,
+       gdk_window_set_functions): Don't call GetWindowLong for
+       GWL_EXSTYLE, the extended window style wasn't used or
+       changed. After setting the window style with SetWindowLong, call
+       SetWindowPos with the SWP_FRAMECHANGED flag for the window to
+       actually be updated, as Platform SDK docs say one should. (#95812,
+       huzheng)
+
 2002-10-28  Dmitry G. Mastrukov  <dmitry@taurussoft.org>
 
        * configure.in: Added Belorusian (be) to ALL_LINGUAS.

diff --git a/ChangeLog.pre-2-10 b/ChangeLog.pre-2-10
index 8d19800e3ce38f047c04a385ad95dbe76b27436e..0baf157a884b2383449b23116f4470229d63b82a 100644 (file)
--- a/ChangeLog.pre-2-10
+++ b/ChangeLog.pre-2-10
@@ -1,3 +1,13 @@
+2002-10-28  Tor Lillqvist  <tml@iki.fi>
+
+       * gdk/win32/gdkwindow-win32.c (gdk_window_set_decorations,
+       gdk_window_set_functions): Don't call GetWindowLong for
+       GWL_EXSTYLE, the extended window style wasn't used or
+       changed. After setting the window style with SetWindowLong, call
+       SetWindowPos with the SWP_FRAMECHANGED flag for the window to
+       actually be updated, as Platform SDK docs say one should. (#95812,
+       huzheng)
+
 2002-10-28  Dmitry G. Mastrukov  <dmitry@taurussoft.org>
 
        * configure.in: Added Belorusian (be) to ALL_LINGUAS.

diff --git a/ChangeLog.pre-2-2 b/ChangeLog.pre-2-2
index 8d19800e3ce38f047c04a385ad95dbe76b27436e..0baf157a884b2383449b23116f4470229d63b82a 100644 (file)
--- a/ChangeLog.pre-2-2
+++ b/ChangeLog.pre-2-2
@@ -1,3 +1,13 @@
+2002-10-28  Tor Lillqvist  <tml@iki.fi>
+
+       * gdk/win32/gdkwindow-win32.c (gdk_window_set_decorations,
+       gdk_window_set_functions): Don't call GetWindowLong for
+       GWL_EXSTYLE, the extended window style wasn't used or
+       changed. After setting the window style with SetWindowLong, call
+       SetWindowPos with the SWP_FRAMECHANGED flag for the window to
+       actually be updated, as Platform SDK docs say one should. (#95812,
+       huzheng)
+
 2002-10-28  Dmitry G. Mastrukov  <dmitry@taurussoft.org>
 
        * configure.in: Added Belorusian (be) to ALL_LINGUAS.

diff --git a/ChangeLog.pre-2-4 b/ChangeLog.pre-2-4
index 8d19800e3ce38f047c04a385ad95dbe76b27436e..0baf157a884b2383449b23116f4470229d63b82a 100644 (file)
--- a/ChangeLog.pre-2-4
+++ b/ChangeLog.pre-2-4
@@ -1,3 +1,13 @@
+2002-10-28  Tor Lillqvist  <tml@iki.fi>
+
+       * gdk/win32/gdkwindow-win32.c (gdk_window_set_decorations,
+       gdk_window_set_functions): Don't call GetWindowLong for
+       GWL_EXSTYLE, the extended window style wasn't used or
+       changed. After setting the window style with SetWindowLong, call
+       SetWindowPos with the SWP_FRAMECHANGED flag for the window to
+       actually be updated, as Platform SDK docs say one should. (#95812,
+       huzheng)
+
 2002-10-28  Dmitry G. Mastrukov  <dmitry@taurussoft.org>
 
        * configure.in: Added Belorusian (be) to ALL_LINGUAS.

diff --git a/ChangeLog.pre-2-6 b/ChangeLog.pre-2-6
index 8d19800e3ce38f047c04a385ad95dbe76b27436e..0baf157a884b2383449b23116f4470229d63b82a 100644 (file)
--- a/ChangeLog.pre-2-6
+++ b/ChangeLog.pre-2-6
@@ -1,3 +1,13 @@
+2002-10-28  Tor Lillqvist  <tml@iki.fi>
+
+       * gdk/win32/gdkwindow-win32.c (gdk_window_set_decorations,
+       gdk_window_set_functions): Don't call GetWindowLong for
+       GWL_EXSTYLE, the extended window style wasn't used or
+       changed. After setting the window style with SetWindowLong, call
+       SetWindowPos with the SWP_FRAMECHANGED flag for the window to
+       actually be updated, as Platform SDK docs say one should. (#95812,
+       huzheng)
+
 2002-10-28  Dmitry G. Mastrukov  <dmitry@taurussoft.org>
 
        * configure.in: Added Belorusian (be) to ALL_LINGUAS.

diff --git a/ChangeLog.pre-2-8 b/ChangeLog.pre-2-8
index 8d19800e3ce38f047c04a385ad95dbe76b27436e..0baf157a884b2383449b23116f4470229d63b82a 100644 (file)
--- a/ChangeLog.pre-2-8
+++ b/ChangeLog.pre-2-8
@@ -1,3 +1,13 @@
+2002-10-28  Tor Lillqvist  <tml@iki.fi>
+
+       * gdk/win32/gdkwindow-win32.c (gdk_window_set_decorations,
+       gdk_window_set_functions): Don't call GetWindowLong for
+       GWL_EXSTYLE, the extended window style wasn't used or
+       changed. After setting the window style with SetWindowLong, call
+       SetWindowPos with the SWP_FRAMECHANGED flag for the window to
+       actually be updated, as Platform SDK docs say one should. (#95812,
+       huzheng)
+
 2002-10-28  Dmitry G. Mastrukov  <dmitry@taurussoft.org>
 
        * configure.in: Added Belorusian (be) to ALL_LINGUAS.

diff --git a/gdk/win32/gdkwindow-win32.c b/gdk/win32/gdkwindow-win32.c
index e57bd626d4f4937fa74e271bad9e658dae1b371a..273cf5a2469b1d8df975dab2d3afd52632b73d65 100644 (file)
--- a/gdk/win32/gdkwindow-win32.c
+++ b/gdk/win32/gdkwindow-win32.c
@@ -45,7 +45,7 @@ static void         gdk_window_impl_win32_set_colormap (GdkDrawable *drawable,
 static void         gdk_window_impl_win32_get_size     (GdkDrawable *drawable,
                                                        gint *width,
                                                        gint *height);
-static GdkRegion*  gdk_window_impl_win32_get_visible_region (GdkDrawable *drawable);
+static GdkRegion*   gdk_window_impl_win32_get_visible_region (GdkDrawable *drawable);
 static void gdk_window_impl_win32_init       (GdkWindowImplWin32      *window);
 static void gdk_window_impl_win32_class_init (GdkWindowImplWin32Class *klass);
 static void gdk_window_impl_win32_finalize   (GObject                 *object);
@@ -2102,19 +2102,26 @@ void
 gdk_window_set_decorations (GdkWindow      *window,
                            GdkWMDecoration decorations)
 {
-  LONG style, exstyle;
+  LONG style;
 
   g_return_if_fail (window != NULL);
   g_return_if_fail (GDK_IS_WINDOW (window));
   
+  GDK_NOTE (MISC, g_print ("gdk_window_set_decorations: %p %s%s%s%s%s%s%s\n",
+                          GDK_WINDOW_HWND (window),
+                          (decorations & GDK_DECOR_ALL ? "ALL " : ""),
+                          (decorations & GDK_DECOR_BORDER ? "BORDER " : ""),
+                          (decorations & GDK_DECOR_RESIZEH ? "RESIZEH " : ""),
+                          (decorations & GDK_DECOR_TITLE ? "TITLE " : ""),
+                          (decorations & GDK_DECOR_MENU ? "MENU " : ""),
+                          (decorations & GDK_DECOR_MINIMIZE ? "MINIMIZE " : ""),
+                          (decorations & GDK_DECOR_MAXIMIZE ? "MAXIMIZE " : "")));
+
   style = GetWindowLong (GDK_WINDOW_HWND (window), GWL_STYLE);
-  exstyle = GetWindowLong (GDK_WINDOW_HWND (window), GWL_EXSTYLE);
 
   style &= (WS_OVERLAPPED|WS_POPUP|WS_CHILD|WS_MINIMIZE|WS_VISIBLE|WS_DISABLED
            |WS_CLIPSIBLINGS|WS_CLIPCHILDREN|WS_MAXIMIZE);
 
-  exstyle &= (WS_EX_TOPMOST|WS_EX_TRANSPARENT);
-
   if (decorations & GDK_DECOR_ALL)
     style |= (WS_CAPTION|WS_SYSMENU|WS_THICKFRAME|WS_MINIMIZEBOX|WS_MAXIMIZEBOX);
   if (decorations & GDK_DECOR_BORDER)
@@ -2131,26 +2138,35 @@ gdk_window_set_decorations (GdkWindow      *window,
     style |= (WS_MAXIMIZEBOX);
   
   SetWindowLong (GDK_WINDOW_HWND (window), GWL_STYLE, style);
+  SetWindowPos (GDK_WINDOW_HWND (window), NULL, 0, 0, 0, 0,
+               SWP_FRAMECHANGED | SWP_NOACTIVATE | SWP_NOMOVE |
+               SWP_NOREPOSITION | SWP_NOSIZE | SWP_NOZORDER);
 }
 
 void
 gdk_window_set_functions (GdkWindow    *window,
                          GdkWMFunction functions)
 {
-  LONG style, exstyle;
+  LONG style;
 
   g_return_if_fail (window != NULL);
   g_return_if_fail (GDK_IS_WINDOW (window));
   
+  GDK_NOTE (MISC, g_print ("gdk_window_set_functions: %p %s%s%s%s%s%s\n",
+                          GDK_WINDOW_HWND (window),
+                          (functions & GDK_FUNC_ALL ? "ALL " : ""),
+                          (functions & GDK_FUNC_RESIZE ? "RESIZE " : ""),
+                          (functions & GDK_FUNC_MOVE ? "MOVE " : ""),
+                          (functions & GDK_FUNC_MINIMIZE ? "MINIMIZE " : ""),
+                          (functions & GDK_FUNC_MAXIMIZE ? "MAXIMIZE " : ""),
+                          (functions & GDK_FUNC_CLOSE ? "CLOSE " : "")));
+
   style = GetWindowLong (GDK_WINDOW_HWND (window), GWL_STYLE);
-  exstyle = GetWindowLong (GDK_WINDOW_HWND (window), GWL_EXSTYLE);
 
   style &= (WS_OVERLAPPED|WS_POPUP|WS_CHILD|WS_MINIMIZE|WS_VISIBLE|WS_DISABLED
            |WS_CLIPSIBLINGS|WS_CLIPCHILDREN|WS_MAXIMIZE|WS_CAPTION|WS_BORDER
            |WS_SYSMENU);
 
-  exstyle &= (WS_EX_TOPMOST|WS_EX_TRANSPARENT);
-
   if (functions & GDK_FUNC_ALL)
     style |= (WS_THICKFRAME|WS_MINIMIZEBOX|WS_MAXIMIZEBOX);
   if (functions & GDK_FUNC_RESIZE)
@@ -2163,19 +2179,15 @@ gdk_window_set_functions (GdkWindow    *window,
     style |= (WS_MAXIMIZEBOX);
   
   SetWindowLong (GDK_WINDOW_HWND (window), GWL_STYLE, style);
+  SetWindowPos (GDK_WINDOW_HWND (window), NULL, 0, 0, 0, 0,
+               SWP_FRAMECHANGED | SWP_NOACTIVATE | SWP_NOMOVE |
+               SWP_NOREPOSITION | SWP_NOSIZE | SWP_NOZORDER);
 }
 
-/* 
- * propagate the shapes from all child windows of a GDK window to the parent 
- * window. Shamelessly ripped from Enlightenment's code
- * 
- * - Raster
- */
-
 static void
-QueryTree (HWND hwnd,
+QueryTree (HWND   hwnd,
           HWND **children,
-          gint *nchildren)
+          gint  *nchildren)
 {
   guint i, n;
   HWND child;
@@ -2536,7 +2548,7 @@ gdk_window_set_modal_hint (GdkWindow *window,
 
   if (GDK_WINDOW_IS_MAPPED (window))
     if (!SetWindowPos (GDK_WINDOW_HWND (window), HWND_TOPMOST,
-                           0, 0, 0, 0, SWP_NOMOVE | SWP_NOSIZE))
+                      0, 0, 0, 0, SWP_NOMOVE | SWP_NOSIZE))
       WIN32_API_FAILED ("SetWindowPos");
 }