]> Pileus Git - ~andy/linux/commitdiff
ioatdma: Fix bug in selftest after removal of DMA_MEMSET.
authorDave Jiang <dave.jiang@intel.com>
Wed, 6 Nov 2013 15:50:09 +0000 (08:50 -0700)
committerDan Williams <dan.j.williams@intel.com>
Thu, 14 Nov 2013 19:04:41 +0000 (11:04 -0800)
Commit 48a9db4 (3.11) removed the memset op in the xor selftest for ioatdma.
The issue is that with the removal of that op, it never replaced the memset
with a CPU memset. The memory being operated on is expected to be zeroes but
was not. This is causing the xor selftest to fail.

Cc: <stable@vger.kernel.org>
Signed-off-by: Dave Jiang <dave.jiang@intel.com>
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
drivers/dma/ioat/dma_v3.c

index a4798f0cc22527b4c4f5e5be88e900491f4d0e68..44786ad2a4cfcf6e112b6eef4ec8105c96e57815 100644 (file)
@@ -1376,6 +1376,8 @@ static int ioat_xor_val_self_test(struct ioatdma_device *device)
                goto free_resources;
        }
 
+       memset(page_address(dest), 0, PAGE_SIZE);
+
        /* test for non-zero parity sum */
        op = IOAT_OP_XOR_VAL;