]> Pileus Git - ~andy/linux/commitdiff
[SCSI] scsi_dh_alua: Fix the time inteval for alua rtpg commands
authorMoger, Babu <Babu.Moger@netapp.com>
Thu, 27 Oct 2011 18:36:32 +0000 (14:36 -0400)
committerJames Bottomley <JBottomley@Parallels.com>
Thu, 3 Nov 2011 07:18:10 +0000 (11:18 +0400)
This patch corrects the retry interval for alua rtpg command. Purpose was to retry the commands in seconds.
But that was not happening. Reason is msleep takes argument in milliseconds.

Also added minor text after successful attach.

Signed-off-by: Babu Moger <babu.moger@netapp.com>
Acked-by: Hannes Reinecke <hare@suse.de>
Signed-off-by: James Bottomley <JBottomley@Parallels.com>
drivers/scsi/device_handler/scsi_dh_alua.c

index 627f4b5e5176b16e9cc969c0b98ac80a85c4afb1..fe4df2da309cad77fd10275459978096e5a9f28a 100644 (file)
@@ -507,7 +507,7 @@ static int alua_rtpg(struct scsi_device *sdev, struct alua_dh_data *h)
        int len, k, off, valid_states = 0;
        unsigned char *ucp;
        unsigned err;
-       unsigned long expiry, interval = 1;
+       unsigned long expiry, interval = 1000;
 
        expiry = round_jiffies_up(jiffies + ALUA_FAILOVER_TIMEOUT);
  retry:
@@ -734,6 +734,7 @@ static int alua_bus_attach(struct scsi_device *sdev)
        spin_lock_irqsave(sdev->request_queue->queue_lock, flags);
        sdev->scsi_dh_data = scsi_dh_data;
        spin_unlock_irqrestore(sdev->request_queue->queue_lock, flags);
+       sdev_printk(KERN_NOTICE, sdev, "%s: Attached\n", ALUA_DH_NAME);
 
        return 0;