]> Pileus Git - ~andy/linux/commitdiff
e1000e: cleanup checkpatch braces checks
authorBruce Allan <bruce.w.allan@intel.com>
Thu, 24 Jan 2013 00:50:18 +0000 (00:50 +0000)
committerJeff Kirsher <jeffrey.t.kirsher@intel.com>
Tue, 5 Feb 2013 08:37:47 +0000 (00:37 -0800)
Resolve the following strict checkpatch checks:
CHECK:BRACES: Blank lines aren't necessary after an open brace '{'
CHECK:BRACES: Blank lines aren't necessary before a close brace '}'
CHECK:BRACES: braces {} should be used on all arms of this statement

Signed-off-by: Bruce Allan <bruce.w.allan@intel.com>
Tested-by: Aaron Brown <aaron.f.brown@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
drivers/net/ethernet/intel/e1000e/82571.c
drivers/net/ethernet/intel/e1000e/ethtool.c
drivers/net/ethernet/intel/e1000e/ich8lan.c
drivers/net/ethernet/intel/e1000e/netdev.c
drivers/net/ethernet/intel/e1000e/phy.c

index 1db7e3df43ea8cacdd497d07311c62eea10e1a37..2faffbde179ef95bf46beb514cf483eb996a204a 100644 (file)
@@ -1534,7 +1534,6 @@ static s32 e1000_check_for_serdes_link_82571(struct e1000_hw *hw)
        rxcw = er32(RXCW);
 
        if ((rxcw & E1000_RXCW_SYNCH) && !(rxcw & E1000_RXCW_IV)) {
-
                /* Receiver is synchronized with no invalid bits.  */
                switch (mac->serdes_link_state) {
                case e1000_serdes_link_autoneg_complete:
index 455e385120b4bd800f85f1224f79eca79f83a2e8..2c1813737f6d2562189065d945a5002750d8e10c 100644 (file)
@@ -130,7 +130,6 @@ static int e1000_get_settings(struct net_device *netdev,
        u32 speed;
 
        if (hw->phy.media_type == e1000_media_type_copper) {
-
                ecmd->supported = (SUPPORTED_10baseT_Half |
                                   SUPPORTED_10baseT_Full |
                                   SUPPORTED_100baseT_Half |
@@ -328,12 +327,12 @@ static int e1000_set_settings(struct net_device *netdev,
        }
 
        /* reset the link */
-
        if (netif_running(adapter->netdev)) {
                e1000e_down(adapter);
                e1000e_up(adapter);
-       } else
+       } else {
                e1000e_reset(adapter);
+       }
 
        clear_bit(__E1000_RESETTING, &adapter->state);
        return 0;
index 1e838b235e8a25f5f6f97f63b923087b39743555..dff7bff8b8e0f1d5ee4e6ca4af510516b3d7fd49 100644 (file)
@@ -3991,7 +3991,6 @@ void e1000_suspend_workarounds_ich8lan(struct e1000_hw *hw)
                 * The SMBus release must also be disabled on LCD reset.
                 */
                if (!(er32(FWSM) & E1000_ICH_FWSM_FW_VALID)) {
-
                        /* Enable proxy to reset only on power good. */
                        e1e_rphy_locked(hw, I217_PROXY_CTRL, &phy_reg);
                        phy_reg |= I217_PROXY_CTRL_AUTO_DISABLE;
index 382b031e7b2a5a6737360dbbfa70d231d092b680..3f7dbd1cdb0f333ffa5409cc269ccd8c305b5093 100644 (file)
@@ -87,7 +87,6 @@ struct e1000_reg_info {
 };
 
 static const struct e1000_reg_info e1000_reg_info_tbl[] = {
-
        /* General Registers */
        {E1000_CTRL, "CTRL"},
        {E1000_STATUS, "STATUS"},
@@ -6394,7 +6393,6 @@ static void e1000_io_resume(struct pci_dev *pdev)
         */
        if (!(adapter->flags & FLAG_HAS_AMT))
                e1000e_get_hw_control(adapter);
-
 }
 
 static void e1000_print_device_info(struct e1000_adapter *adapter)
index a5ff13b9ef867b63a78dd4f862a1a2f301214c8f..0930c136aa310644d8117c63cad3f87868ff54f7 100644 (file)
@@ -2474,7 +2474,6 @@ s32 e1000e_read_phy_reg_bm2(struct e1000_hw *hw, u32 offset, u16 *data)
        hw->phy.addr = 1;
 
        if (offset > MAX_PHY_MULTI_PAGE_REG) {
-
                /* Page is shifted left, PHY expects (page x 32) */
                ret_val = e1000e_write_phy_reg_mdic(hw, BM_PHY_PAGE_SELECT,
                                                    page);