]> Pileus Git - ~andy/linux/commitdiff
staging: vt6656: Don't needlessly test for NULL before release_firmware()
authorJesper Juhl <jj@chaosbits.net>
Mon, 9 Apr 2012 20:51:58 +0000 (22:51 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 18 Apr 2012 23:37:05 +0000 (16:37 -0700)
Checking for a NULL pointer before calling release_firmware() is
redundant since the function does that check itself.

Signed-off-by: Jesper Juhl <jj@chaosbits.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/vt6656/main_usb.c

index 763e028a5cc57e734c703acdca058df253af319d..ee5261a36886e4d57e6722ae48bf3eacad37edf5 100644 (file)
@@ -1257,9 +1257,7 @@ static void __devexit vt6656_disconnect(struct usb_interface *intf)
        }
 
        device_release_WPADEV(device);
-
-       if (device->firmware)
-               release_firmware(device->firmware);
+       release_firmware(device->firmware);
 
        usb_set_intfdata(intf, NULL);
        usb_put_dev(interface_to_usbdev(intf));