]> Pileus Git - ~andy/linux/commitdiff
ASoC: rcar: some dubious one-bit signed bitfields
authorDan Carpenter <dan.carpenter@oracle.com>
Fri, 8 Nov 2013 09:46:53 +0000 (12:46 +0300)
committerMark Brown <broonie@linaro.org>
Sun, 24 Nov 2013 13:42:44 +0000 (13:42 +0000)
Because these are signed they can either be 0 or -1 instead of 0 and 1
as intended.  It doesn't cause a problem from what I can see, but it's
dangerous and Sparse complains:

sound/soc/sh/rcar/rsnd.h:177:25:
error: dubious one-bit signed bitfield

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Mark Brown <broonie@linaro.org>
sound/soc/sh/rcar/rsnd.h

index 9e463e50e7e62b81fabeaeecf39f50de4206eeaf..b5ac3a2afc582ae237514873b34cda5c392cd1dd 100644 (file)
@@ -174,11 +174,11 @@ struct rsnd_dai {
        struct rsnd_dai_stream playback;
        struct rsnd_dai_stream capture;
 
-       int clk_master:1;
-       int bit_clk_inv:1;
-       int frm_clk_inv:1;
-       int sys_delay:1;
-       int data_alignment:1;
+       unsigned int clk_master:1;
+       unsigned int bit_clk_inv:1;
+       unsigned int frm_clk_inv:1;
+       unsigned int sys_delay:1;
+       unsigned int data_alignment:1;
 };
 
 #define rsnd_dai_nr(priv) ((priv)->dai_nr)