GtkTreeView: Don't short-circuit header-height calculation

The code was putting header_height at zero when there is
no model. That leads to temporary underallocation of header
buttons.

diff --git a/gtk/gtktreeview.c b/gtk/gtktreeview.c
index 969af40e3ae2924b4a006d5fa1fad51eb3654cc9..60dee949c30a5f786009d3cc8d02d8684215282a 100644 (file)
--- a/gtk/gtktreeview.c
+++ b/gtk/gtktreeview.c
@@ -2367,22 +2367,17 @@ gtk_tree_view_size_request_columns (GtkTreeView *tree_view)
 
   tree_view->priv->header_height = 0;
 
-  if (tree_view->priv->model)
+  for (list = tree_view->priv->columns; list; list = list->next)
     {
-      for (list = tree_view->priv->columns; list; list = list->next)
-        {
-          GtkRequisition     requisition;
-          GtkTreeViewColumn *column = list->data;
-         GtkWidget         *button = gtk_tree_view_column_get_button (column);
-
-         if (button == NULL)
-           continue;
+      GtkRequisition     requisition;
+      GtkTreeViewColumn *column = list->data;
+      GtkWidget         *button = gtk_tree_view_column_get_button (column);
 
-          column = list->data;
+      if (button == NULL)
+        continue;
 
-          gtk_widget_get_preferred_size (button, &requisition, NULL);
-          tree_view->priv->header_height = MAX (tree_view->priv->header_height, requisition.height);
-        }
+      gtk_widget_get_preferred_size (button, &requisition, NULL);
+      tree_view->priv->header_height = MAX (tree_view->priv->header_height, requisition.height);
     }
 }