Remove unecessary hard-coding of EDITOR=':' VISUAL=':' in some test suites.

They are already set and exoprted by sourcing ./test-lib.sh
in all test scripts.

Signed-off-by: Kristian Høgsberg <krh@redhat.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>

diff --git a/t/t3501-revert-cherry-pick.sh b/t/t3501-revert-cherry-pick.sh
index 552af1c4d2f7ecc78e3264290e4d82580f464ead..2dbe04fb20aea9a18e6fe751539bcb48e5e7b4d3 100755 (executable)
--- a/t/t3501-revert-cherry-pick.sh
+++ b/t/t3501-revert-cherry-pick.sh
@@ -44,7 +44,7 @@ test_expect_success setup '
 test_expect_success 'cherry-pick after renaming branch' '
 
        git checkout rename2 &&
-       EDITOR=: VISUAL=: git cherry-pick added &&
+       git cherry-pick added &&
        test -f opos &&
        grep "Add extra line at the end" opos
 
@@ -53,7 +53,7 @@ test_expect_success 'cherry-pick after renaming branch' '
 test_expect_success 'revert after renaming branch' '
 
        git checkout rename1 &&
-       EDITOR=: VISUAL=: git revert added &&
+       git revert added &&
        test -f spoo &&
        ! grep "Add extra line at the end" spoo
 

diff --git a/t/t3901-i18n-patch.sh b/t/t3901-i18n-patch.sh
index 28e9e372f34818ab5427ef0178dc2003a8018656..235f372832cb32aefff0a00c4f2ac0e19de2e55d 100755 (executable)
--- a/t/t3901-i18n-patch.sh
+++ b/t/t3901-i18n-patch.sh
@@ -154,7 +154,7 @@ test_expect_success 'cherry-pick(U/U)' '
        git reset --hard master &&
        git cherry-pick side^ &&
        git cherry-pick side &&
-       EDITOR=: VISUAL=: git revert HEAD &&
+       git revert HEAD &&
 
        check_encoding 3
 '
@@ -169,7 +169,7 @@ test_expect_success 'cherry-pick(L/L)' '
        git reset --hard master &&
        git cherry-pick side^ &&
        git cherry-pick side &&
-       EDITOR=: VISUAL=: git revert HEAD &&
+       git revert HEAD &&
 
        check_encoding 3 8859
 '
@@ -184,7 +184,7 @@ test_expect_success 'cherry-pick(U/L)' '
        git reset --hard master &&
        git cherry-pick side^ &&
        git cherry-pick side &&
-       EDITOR=: VISUAL=: git revert HEAD &&
+       git revert HEAD &&
 
        check_encoding 3
 '
@@ -200,7 +200,7 @@ test_expect_success 'cherry-pick(L/U)' '
        git reset --hard master &&
        git cherry-pick side^ &&
        git cherry-pick side &&
-       EDITOR=: VISUAL=: git revert HEAD &&
+       git revert HEAD &&
 
        check_encoding 3 8859
 '