]> Pileus Git - ~andy/linux/commitdiff
drm/prime: warn for non-empty handle lookup list during drm file release
authorImre Deak <imre.deak@intel.com>
Wed, 24 Apr 2013 16:04:57 +0000 (19:04 +0300)
committerDave Airlie <airlied@redhat.com>
Wed, 1 May 2013 06:08:18 +0000 (16:08 +1000)
drm_gem_release should release all handles connected to the drm file and
so should also release the prime lookup entries of these handles. So
just WARN if this isn't the case.

Signed-off-by: Imre Deak <imre.deak@intel.com>
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Signed-off-by: Dave Airlie <airlied@redhat.com>
drivers/gpu/drm/drm_prime.c

index 71c7315ca00f26c6e4567172c79bc59c0639d727..dcde35231e259c83460b9dfb8bb9b4a1514ca3a5 100644 (file)
@@ -488,11 +488,8 @@ EXPORT_SYMBOL(drm_prime_init_file_private);
 
 void drm_prime_destroy_file_private(struct drm_prime_file_private *prime_fpriv)
 {
-       struct drm_prime_member *member, *safe;
-       list_for_each_entry_safe(member, safe, &prime_fpriv->head, entry) {
-               list_del(&member->entry);
-               kfree(member);
-       }
+       /* by now drm_gem_release should've made sure the list is empty */
+       WARN_ON(!list_empty(&prime_fpriv->head));
 }
 EXPORT_SYMBOL(drm_prime_destroy_file_private);