]> Pileus Git - ~andy/linux/commitdiff
OMAPDSS: TPO-TD03MTEA1: Check for errors from regulator_enable()
authorMark Brown <broonie@opensource.wolfsonmicro.com>
Mon, 19 Mar 2012 15:02:31 +0000 (15:02 +0000)
committerTomi Valkeinen <tomi.valkeinen@ti.com>
Mon, 23 Apr 2012 07:48:05 +0000 (10:48 +0300)
It is possible for regulator_enable() to fail and if it does fail that's
generally a bad sign for anything we try to do with the hardware afterwards
so check for and immediately return an error if regulator_enable() fails.

Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
Acked-by: Grazvydas Ignotas <notasas@gmail.com>
Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
drivers/video/omap2/displays/panel-tpo-td043mtea1.c

index 32f3fcd7f0f0adc8361523035ce5435412578424..74c6b873932bf3bacba93f38b23f7fd167875990 100644 (file)
@@ -272,11 +272,14 @@ static const struct omap_video_timings tpo_td043_timings = {
 static int tpo_td043_power_on(struct tpo_td043_device *tpo_td043)
 {
        int nreset_gpio = tpo_td043->nreset_gpio;
+       int r;
 
        if (tpo_td043->powered_on)
                return 0;
 
-       regulator_enable(tpo_td043->vcc_reg);
+       r = regulator_enable(tpo_td043->vcc_reg);
+       if (r != 0)
+               return r;
 
        /* wait for regulator to stabilize */
        msleep(160);