]> Pileus Git - ~andy/linux/commitdiff
net: calxedaxgmac: drop some unnecessary register writes
authorRob Herring <rob.herring@calxeda.com>
Mon, 5 Nov 2012 06:22:22 +0000 (06:22 +0000)
committerDavid S. Miller <davem@davemloft.net>
Wed, 7 Nov 2012 08:51:14 +0000 (03:51 -0500)
The interrupts have already been cleared, so we don't need to clear them
again. Also, we could miss interrupts if they are cleared, but we don't
process the packet.

Signed-off-by: Rob Herring <rob.herring@calxeda.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/calxeda/xgmac.c

index 84cd40e4f081dc76d012cfe7f1210a99bab33dd5..826321910efc481ff39ac4fb3cf03a0ac5ea1d96 100644 (file)
@@ -846,9 +846,6 @@ static void xgmac_free_dma_desc_rings(struct xgmac_priv *priv)
 static void xgmac_tx_complete(struct xgmac_priv *priv)
 {
        int i;
-       void __iomem *ioaddr = priv->base;
-
-       writel(DMA_STATUS_TU | DMA_STATUS_NIS, ioaddr + XGMAC_DMA_STATUS);
 
        while (dma_ring_cnt(priv->tx_head, priv->tx_tail, DMA_TX_RING_SZ)) {
                unsigned int entry = priv->tx_tail;
@@ -1139,9 +1136,6 @@ static int xgmac_rx(struct xgmac_priv *priv, int limit)
                struct sk_buff *skb;
                int frame_len;
 
-               writel(DMA_STATUS_RI | DMA_STATUS_NIS,
-                      priv->base + XGMAC_DMA_STATUS);
-
                entry = priv->rx_tail;
                p = priv->dma_rx + entry;
                if (desc_get_owner(p))