]> Pileus Git - ~andy/linux/commitdiff
staging: comedi: addi_apci_1032: fix subdevice type/flags bug
authorH Hartley Sweeten <hsweeten@visionengravers.com>
Mon, 9 Dec 2013 23:06:41 +0000 (16:06 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 17 Dec 2013 18:03:03 +0000 (10:03 -0800)
The SDF_CMD_READ should be one of the s->subdev_flags not part of
the s->type.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/comedi/drivers/addi_apci_1032.c

index af2306c1b649b5d56f11c9aa9a37bef9e5f64abf..0daa0ea63b5ef1fa11decb610a2e24662e8c80be 100644 (file)
@@ -325,8 +325,8 @@ static int apci1032_auto_attach(struct comedi_device *dev,
        s = &dev->subdevices[1];
        if (dev->irq) {
                dev->read_subdev = s;
-               s->type         = COMEDI_SUBD_DI | SDF_CMD_READ;
-               s->subdev_flags = SDF_READABLE;
+               s->type         = COMEDI_SUBD_DI;
+               s->subdev_flags = SDF_READABLE | SDF_CMD_READ;
                s->n_chan       = 1;
                s->maxdata      = 1;
                s->range_table  = &range_digital;