]> Pileus Git - ~andy/linux/commitdiff
MIPS: irq: Remove IRQF_DISABLED
authorYong Zhang <yong.zhang0@gmail.com>
Tue, 22 Nov 2011 14:38:03 +0000 (14:38 +0000)
committerRalf Baechle <ralf@linux-mips.org>
Wed, 7 Dec 2011 22:03:45 +0000 (22:03 +0000)
Since commit [e58aa3d2: genirq: Run irq handlers with interrupts disabled],
We run all interrupt handlers with interrupts disabled and we even check
and yell when an interrupt handler returns with interrupts enabled (see
commit [b738a50a: genirq: Warn when handler enables interrupts]).

So now this flag is a NOOP and can be removed.

[ralf@linux-mips.org: Fixed up conflicts in
arch/mips/alchemy/common/dbdma.c, arch/mips/cavium-octeon/smp.c and
arch/mips/kernel/perf_event.c.]

Signed-off-by: Yong Zhang <yong.zhang0@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: tglx@linutronix.de
linux-mips@linux-mips.org
Patchwork: https://patchwork.linux-mips.org/patch/2835/
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
35 files changed:
arch/mips/alchemy/common/dbdma.c
arch/mips/alchemy/common/time.c
arch/mips/alchemy/devboards/db1200/platform.c
arch/mips/dec/setup.c
arch/mips/include/asm/mach-generic/floppy.h
arch/mips/include/asm/mach-jazz/floppy.h
arch/mips/jazz/irq.c
arch/mips/kernel/cevt-bcm1480.c
arch/mips/kernel/cevt-ds1287.c
arch/mips/kernel/cevt-gt641xx.c
arch/mips/kernel/cevt-r4k.c
arch/mips/kernel/cevt-sb1250.c
arch/mips/kernel/cevt-txx9.c
arch/mips/kernel/i8253.c
arch/mips/kernel/rtlx.c
arch/mips/kernel/smtc.c
arch/mips/lantiq/irq.c
arch/mips/loongson/common/cs5536/cs5536_mfgpt.c
arch/mips/mti-malta/malta-int.c
arch/mips/pci/ops-pmcmsp.c
arch/mips/pci/ops-tx3927.c
arch/mips/pci/pci-tx4927.c
arch/mips/pci/pci-tx4938.c
arch/mips/pci/pci-tx4939.c
arch/mips/pmc-sierra/msp71xx/msp_hwbutton.c
arch/mips/pmc-sierra/msp71xx/msp_smp.c
arch/mips/pnx8550/common/int.c
arch/mips/pnx8550/common/time.c
arch/mips/sgi-ip22/ip22-int.c
arch/mips/sgi-ip27/ip27-irq.c
arch/mips/sgi-ip27/ip27-timer.c
arch/mips/sgi-ip32/ip32-irq.c
arch/mips/sni/irq.c
arch/mips/sni/time.c
arch/mips/txx9/generic/pci.c

index 0e63ee487d6d1315b6f06c069631cb383c932eb7..9ba407b4fc975a59fdab1877382d2ba786f05237 100644 (file)
@@ -1019,8 +1019,7 @@ static int __init dbdma_setup(unsigned int irq, dbdev_tab_t *idtable)
        dbdma_gptr->ddma_inten = 0xffff;
        au_sync();
 
-       ret = request_irq(irq, dbdma_interrupt, IRQF_DISABLED, "dbdma",
-                         (void *)dbdma_gptr);
+       ret = request_irq(irq, dbdma_interrupt, 0, "dbdma", (void *)dbdma_gptr);
        if (ret)
                printk(KERN_ERR "Cannot grab DBDMA interrupt!\n");
        else {
index d5da6adbf63491566330f9a22309c69274d132ad..146a5fa803609c7ec1d85890025b88d0c23b0a52 100644 (file)
@@ -92,7 +92,7 @@ static struct clock_event_device au1x_rtcmatch2_clockdev = {
 
 static struct irqaction au1x_rtcmatch2_irqaction = {
        .handler        = au1x_rtcmatch2_irq,
-       .flags          = IRQF_DISABLED | IRQF_TIMER,
+       .flags          = IRQF_TIMER,
        .name           = "timer",
        .dev_id         = &au1x_rtcmatch2_clockdev,
 };
index c61867c93c4ab49c44c6c9b7df8387cc2f2adac3..78459c17c62808a01c3bc723b499ce84b81d7253 100644 (file)
@@ -276,12 +276,12 @@ static int db1200_mmc_cd_setup(void *mmc_host, int en)
 
        if (en) {
                ret = request_irq(DB1200_SD0_INSERT_INT, db1200_mmc_cd,
-                                 IRQF_DISABLED, "sd_insert", mmc_host);
+                                 0, "sd_insert", mmc_host);
                if (ret)
                        goto out;
 
                ret = request_irq(DB1200_SD0_EJECT_INT, db1200_mmc_cd,
-                                 IRQF_DISABLED, "sd_eject", mmc_host);
+                                 0, "sd_eject", mmc_host);
                if (ret) {
                        free_irq(DB1200_SD0_INSERT_INT, mmc_host);
                        goto out;
index f7b7ba6d5c45f589951f301bca6f29bc1e8bacba..b874accd878a7cc33bfea390526e8f67340765de 100644 (file)
@@ -110,7 +110,6 @@ static struct irqaction fpuirq = {
 };
 
 static struct irqaction busirq = {
-       .flags = IRQF_DISABLED,
        .name = "bus error",
        .flags = IRQF_NO_THREAD,
 };
index 001a8ce17c1733f390291451b5c87985efbd97dd..a38f4d43e5e575e8ad47145ae5c5b3729f284488 100644 (file)
@@ -98,7 +98,7 @@ static inline void fd_disable_irq(void)
 static inline int fd_request_irq(void)
 {
        return request_irq(FLOPPY_IRQ, floppy_interrupt,
-                          IRQF_DISABLED, "floppy", NULL);
+                          0, "floppy", NULL);
 }
 
 static inline void fd_free_irq(void)
index 56e9ca6ae426b28923c57f084b82ede0411193db..88b5acb751456ce520501b387088cbf4b1150be7 100644 (file)
@@ -90,7 +90,7 @@ static inline void fd_disable_irq(void)
 static inline int fd_request_irq(void)
 {
        return request_irq(FLOPPY_IRQ, floppy_interrupt,
-                          IRQF_DISABLED, "floppy", NULL);
+                          0, "floppy", NULL);
 }
 
 static inline void fd_free_irq(void)
index ca9bd206914257e2479e9b750653f05790ad887d..0f4a14752a7bf4d9568e281757faf3af5f5476ec 100644 (file)
@@ -133,7 +133,7 @@ static irqreturn_t r4030_timer_interrupt(int irq, void *dev_id)
 
 static struct irqaction r4030_timer_irqaction = {
        .handler        = r4030_timer_interrupt,
-       .flags          = IRQF_DISABLED | IRQF_TIMER,
+       .flags          = IRQF_TIMER,
        .name           = "R4030 timer",
 };
 
index 36c3898b76dbb01182184744fec80056c1132cd8..69bbfae183bcfafd46f4c4b559e3368233085df2 100644 (file)
@@ -145,7 +145,7 @@ void __cpuinit sb1480_clockevent_init(void)
        bcm1480_unmask_irq(cpu, irq);
 
        action->handler = sibyte_counter_handler;
-       action->flags   = IRQF_DISABLED | IRQF_PERCPU | IRQF_TIMER;
+       action->flags   = IRQF_PERCPU | IRQF_TIMER;
        action->name    = name;
        action->dev_id  = cd;
 
index 939157e397b940fd811d348997840c9dc34a0a0b..ed648cb5a69fcc9229fcecbdcb70f30d55c55656 100644 (file)
@@ -108,7 +108,7 @@ static irqreturn_t ds1287_interrupt(int irq, void *dev_id)
 
 static struct irqaction ds1287_irqaction = {
        .handler        = ds1287_interrupt,
-       .flags          = IRQF_DISABLED | IRQF_PERCPU | IRQF_TIMER,
+       .flags          = IRQF_PERCPU | IRQF_TIMER,
        .name           = "ds1287",
 };
 
index 339f3639b90e463d41931b7b127c3173e74297af..831b47585b7ceac273790c2cfa92ffff4160e0c4 100644 (file)
@@ -114,7 +114,7 @@ static irqreturn_t gt641xx_timer0_interrupt(int irq, void *dev_id)
 
 static struct irqaction gt641xx_timer0_irqaction = {
        .handler        = gt641xx_timer0_interrupt,
-       .flags          = IRQF_DISABLED | IRQF_PERCPU | IRQF_TIMER,
+       .flags          = IRQF_PERCPU | IRQF_TIMER,
        .name           = "gt641xx_timer0",
 };
 
index e2d8e199be323345a6feaf3eb03a738e515dd5f5..51095dd9599d307605caeb8c2aca9e99a0e8dce1 100644 (file)
@@ -84,7 +84,7 @@ out:
 
 struct irqaction c0_compare_irqaction = {
        .handler = c0_compare_interrupt,
-       .flags = IRQF_DISABLED | IRQF_PERCPU | IRQF_TIMER,
+       .flags = IRQF_PERCPU | IRQF_TIMER,
        .name = "timer",
 };
 
index 590c54f28a81772f961b2513fef1147d4d581f62..e73439fd685078114996819991dac66a4181fe9e 100644 (file)
@@ -144,7 +144,7 @@ void __cpuinit sb1250_clockevent_init(void)
        sb1250_unmask_irq(cpu, irq);
 
        action->handler = sibyte_counter_handler;
-       action->flags   = IRQF_DISABLED | IRQF_PERCPU | IRQF_TIMER;
+       action->flags   = IRQF_PERCPU | IRQF_TIMER;
        action->name    = name;
        action->dev_id  = cd;
 
index f0ab92a1b0573b49637f648b9e36c91adf14ae48..e5c30b1d0860f5e1e669070619833f4605cfef1c 100644 (file)
@@ -146,7 +146,7 @@ static irqreturn_t txx9tmr_interrupt(int irq, void *dev_id)
 
 static struct irqaction txx9tmr_irq = {
        .handler        = txx9tmr_interrupt,
-       .flags          = IRQF_DISABLED | IRQF_PERCPU | IRQF_TIMER,
+       .flags          = IRQF_PERCPU | IRQF_TIMER,
        .name           = "txx9tmr",
        .dev_id         = &txx9_clock_event_device,
 };
index 7047bff35ea52829a85a9fc94e8f33ad05ead786..c5bc344fc745c4b45a0daa40ea09447f49834cd4 100644 (file)
@@ -19,7 +19,7 @@ static irqreturn_t timer_interrupt(int irq, void *dev_id)
 
 static struct irqaction irq0  = {
        .handler = timer_interrupt,
-       .flags = IRQF_DISABLED | IRQF_NOBALANCING | IRQF_TIMER,
+       .flags = IRQF_NOBALANCING | IRQF_TIMER,
        .name = "timer"
 };
 
index 933166f44a6d8647c4f75deaf13b11a02e04adaf..a9d801dec6b03c77b0ab5a1d05fa691798f59be1 100644 (file)
@@ -473,7 +473,6 @@ static const struct file_operations rtlx_fops = {
 
 static struct irqaction rtlx_irq = {
        .handler        = rtlx_interrupt,
-       .flags          = IRQF_DISABLED,
        .name           = "RTLX",
 };
 
index f0895e70e283b3982c18a672ad8875a8b1e6ad55..17c9412b5f4274e255e3da951b27a95b2db9e9ca 100644 (file)
@@ -1130,7 +1130,7 @@ static void ipi_irq_dispatch(void)
 
 static struct irqaction irq_ipi = {
        .handler        = ipi_interrupt,
-       .flags          = IRQF_DISABLED | IRQF_PERCPU,
+       .flags          = IRQF_PERCPU,
        .name           = "SMTC_IPI"
 };
 
index f9737bb3c5ab7442b055a6d0d7aa0e7529b37b6d..3c56179b4ca2211db05b51e0fa43446abac7ef02 100644 (file)
@@ -240,7 +240,6 @@ out:
 
 static struct irqaction cascade = {
        .handler = no_action,
-       .flags = IRQF_DISABLED,
        .name = "cascade",
 };
 
index 0cb1b9760e34f32c19b57f8a0de4f9442766190e..5d1f48fa1a527a22bde62471e8c9fd3321b11225 100644 (file)
@@ -111,7 +111,7 @@ static irqreturn_t timer_interrupt(int irq, void *dev_id)
 
 static struct irqaction irq5 = {
        .handler = timer_interrupt,
-       .flags = IRQF_DISABLED | IRQF_NOBALANCING | IRQF_TIMER,
+       .flags = IRQF_NOBALANCING | IRQF_TIMER,
        .name = "timer"
 };
 
index d53ff91b277c8f358a96058ddffada9901345ba1..a588b5cef8d2a8bed4003ee9b0056932f81a78e0 100644 (file)
@@ -322,13 +322,13 @@ static irqreturn_t ipi_call_interrupt(int irq, void *dev_id)
 
 static struct irqaction irq_resched = {
        .handler        = ipi_resched_interrupt,
-       .flags          = IRQF_DISABLED|IRQF_PERCPU,
+       .flags          = IRQF_PERCPU,
        .name           = "IPI_resched"
 };
 
 static struct irqaction irq_call = {
        .handler        = ipi_call_interrupt,
-       .flags          = IRQF_DISABLED|IRQF_PERCPU,
+       .flags          = IRQF_PERCPU,
        .name           = "IPI_call"
 };
 #endif /* CONFIG_MIPS_MT_SMP */
index 8fbfbf2b931c66134491b48c57beb8a1481a05a2..389bf669d56e7d4a9cf4b4c04c537537bc0b3cc0 100644 (file)
@@ -405,7 +405,7 @@ int msp_pcibios_config_access(unsigned char access_type,
        if (pciirqflag == 0) {
                ret = request_irq(MSP_INT_PCI,/* Hardcoded internal MSP7120 wiring */
                                bpci_interrupt,
-                               IRQF_SHARED | IRQF_DISABLED,
+                               IRQF_SHARED,
                                "PMC MSP PCI Host",
                                preg);
                if (ret != 0)
index 6a3bdb5ffa8074e5ba3e978d6989115857e17e5b..02d64f77e967468d9117b1d7cd26b48cca4af313 100644 (file)
@@ -225,7 +225,7 @@ void __init tx3927_setup_pcierr_irq(void)
 {
        if (request_irq(TXX9_IRQ_BASE + TX3927_IR_PCI,
                        tx3927_pcierr_interrupt,
-                       IRQF_DISABLED, "PCI error",
+                       0, "PCI error",
                        (void *)TX3927_PCIC_REG))
                printk(KERN_WARNING "Failed to request irq for PCIERR\n");
 }
index a5807406a7f168bc62535319b84effd5756644e6..a032ae0a533dce2d8afc1d7fe94936037679661e 100644 (file)
@@ -85,7 +85,7 @@ void __init tx4927_setup_pcierr_irq(void)
 {
        if (request_irq(TXX9_IRQ_BASE + TX4927_IR_PCIERR,
                        tx4927_pcierr_interrupt,
-                       IRQF_DISABLED, "PCI error",
+                       0, "PCI error",
                        (void *)TX4927_PCIC_REG))
                printk(KERN_WARNING "Failed to request irq for PCIERR\n");
 }
index 20e45f30b2ef4274037dcac4ae63665a13c49c7f..141bba562488d1d37fef412804952c34dff45dd9 100644 (file)
@@ -136,7 +136,7 @@ void __init tx4938_setup_pcierr_irq(void)
 {
        if (request_irq(TXX9_IRQ_BASE + TX4938_IR_PCIERR,
                        tx4927_pcierr_interrupt,
-                       IRQF_DISABLED, "PCI error",
+                       0, "PCI error",
                        (void *)TX4927_PCIC_REG))
                printk(KERN_WARNING "Failed to request irq for PCIERR\n");
 }
index 9ef840693baf820fa336453d6fc47a4738c783a3..c10fbf2a19dc761ec16095e4f8fddb0c62e8cb3d 100644 (file)
@@ -101,7 +101,7 @@ void __init tx4939_setup_pcierr_irq(void)
 {
        if (request_irq(TXX9_IRQ_BASE + TX4939_IR_PCIERR,
                        tx4927_pcierr_interrupt,
-                       IRQF_DISABLED, "PCI error",
+                       0, "PCI error",
                        (void *)TX4939_PCIC_REG))
                pr_warning("Failed to request irq for PCIERR\n");
 }
index c841f083a7f55644d1d62829591ef26cdf954c15..bb57ed9ea2bd73c01a139500614c70f61d531cd1 100644 (file)
@@ -149,7 +149,7 @@ static int msp_hwbutton_register(struct hwbutton_interrupt *hirq)
                CIC_EXT_SET_ACTIVE_HI(cic_ext, hirq->eirq);
        *CIC_EXT_CFG_REG = cic_ext;
 
-       return request_irq(hirq->irq, hwbutton_handler, IRQF_DISABLED,
+       return request_irq(hirq->irq, hwbutton_handler, 0,
                           hirq->name, hirq);
 }
 
index bec17901ff03aae58814451a16d13487ed1b8ff9..10170580a2def4501bb4f149c707d050a900246f 100644 (file)
@@ -51,13 +51,13 @@ static irqreturn_t ipi_call_interrupt(int irq, void *dev_id)
 
 static struct irqaction irq_resched = {
        .handler        = ipi_resched_interrupt,
-       .flags          = IRQF_DISABLED | IRQF_PERCPU,
+       .flags          = IRQF_PERCPU,
        .name           = "IPI_resched"
 };
 
 static struct irqaction irq_call = {
        .handler        = ipi_call_interrupt,
-       .flags          = IRQF_DISABLED | IRQF_PERCPU,
+       .flags          = IRQF_PERCPU,
        .name           = "IPI_call"
 };
 
index 1ebe22bdadc87668c35587687434af376876bafc..ec684b8c3f7990b65e4ccf974a8e102457edad66 100644 (file)
@@ -167,13 +167,13 @@ static struct irq_chip level_irq_type = {
 
 static struct irqaction gic_action = {
        .handler =      no_action,
-       .flags =        IRQF_DISABLED | IRQF_NO_THREAD,
+       .flags =        IRQF_NO_THREAD,
        .name =         "GIC",
 };
 
 static struct irqaction timer_action = {
        .handler =      no_action,
-       .flags =        IRQF_DISABLED | IRQF_TIMER,
+       .flags =        IRQF_TIMER,
        .name =         "Timer",
 };
 
index 8836c6203df0994fcdd1084fba3c681ed7b483c7..831d6b369e9c7c19d49e94c21cc8dad87b36018d 100644 (file)
@@ -59,7 +59,7 @@ static irqreturn_t pnx8xxx_timer_interrupt(int irq, void *dev_id)
 
 static struct irqaction pnx8xxx_timer_irq = {
        .handler        = pnx8xxx_timer_interrupt,
-       .flags          = IRQF_DISABLED | IRQF_PERCPU | IRQF_TIMER,
+       .flags          = IRQF_PERCPU | IRQF_TIMER,
        .name           = "pnx8xxx_timer",
 };
 
@@ -72,7 +72,7 @@ static irqreturn_t monotonic_interrupt(int irq, void *dev_id)
 
 static struct irqaction monotonic_irqaction = {
        .handler = monotonic_interrupt,
-       .flags = IRQF_DISABLED | IRQF_TIMER,
+       .flags = IRQF_TIMER,
        .name = "Monotonic timer",
 };
 
index f72c336ea27b3b059ca4c6a169e3b1cefce23d47..3f2b7633f946a6bbe020d80f4643ad253789da82 100644 (file)
@@ -155,32 +155,32 @@ static void __irq_entry indy_buserror_irq(void)
 
 static struct irqaction local0_cascade = {
        .handler        = no_action,
-       .flags          = IRQF_DISABLED | IRQF_NO_THREAD,
+       .flags          = IRQF_NO_THREAD,
        .name           = "local0 cascade",
 };
 
 static struct irqaction local1_cascade = {
        .handler        = no_action,
-       .flags          = IRQF_DISABLED | IRQF_NO_THREAD,
+       .flags          = IRQF_NO_THREAD,
        .name           = "local1 cascade",
 };
 
 static struct irqaction buserr = {
        .handler        = no_action,
-       .flags          = IRQF_DISABLED | IRQF_NO_THREAD,
+       .flags          = IRQF_NO_THREAD,
        .name           = "Bus Error",
 };
 
 static struct irqaction map0_cascade = {
        .handler        = no_action,
-       .flags          = IRQF_DISABLED | IRQF_NO_THREAD,
+       .flags          = IRQF_NO_THREAD,
        .name           = "mapable0 cascade",
 };
 
 #ifdef USE_LIO3_IRQ
 static struct irqaction map1_cascade = {
        .handler        = no_action,
-       .flags          = IRQF_DISABLED | IRQF_NO_THREAD,
+       .flags          = IRQF_NO_THREAD,
        .name           = "mapable1 cascade",
 };
 #define SGI_INTERRUPTS SGINT_END
index f90dce315e0477b960cd68e01002794612bbb101..888eac1b8311f8d9b140443513af06f226724472 100644 (file)
@@ -116,7 +116,7 @@ static int ms1bit(unsigned long x)
 }
 
 /*
- * This code is unnecessarily complex, because we do IRQF_DISABLED
+ * This code is unnecessarily complex, because we do
  * intr enabling. Basically, once we grab the set of intrs we need
  * to service, we must mask _all_ these interrupts; firstly, to make
  * sure the same intr does not intr again, causing recursion that
index ef74f3267f9102bfa870e713311520d94fe6c723..13cfeab50528e7bdef1e384784ac9b6f7c19f699 100644 (file)
@@ -91,7 +91,7 @@ static irqreturn_t hub_rt_counter_handler(int irq, void *dev_id)
 
 struct irqaction hub_rt_irqaction = {
        .handler        = hub_rt_counter_handler,
-       .flags          = IRQF_DISABLED | IRQF_PERCPU | IRQF_TIMER,
+       .flags          = IRQF_PERCPU | IRQF_TIMER,
        .name           = "hub-rt",
 };
 
index c65ea76d56c78a831b24603522b35207088c9a59..a092860d5196818b1f4942dc4070af4abdac1bdc 100644 (file)
@@ -113,13 +113,11 @@ extern irqreturn_t crime_cpuerr_intr(int irq, void *dev_id);
 
 static struct irqaction memerr_irq = {
        .handler = crime_memerr_intr,
-       .flags = IRQF_DISABLED,
        .name = "CRIME memory error",
 };
 
 static struct irqaction cpuerr_irq = {
        .handler = crime_cpuerr_intr,
-       .flags = IRQF_DISABLED,
        .name = "CRIME CPU error",
 };
 
index e8e72bb3a9afa13e2a0f91655be9af684f2d81fe..5a4ec75382e2eb301e302b5ab658a42ed565a56d 100644 (file)
@@ -42,7 +42,7 @@ static irqreturn_t sni_isa_irq_handler(int dummy, void *p)
 struct irqaction sni_isa_irq = {
        .handler = sni_isa_irq_handler,
        .name = "ISA",
-       .flags = IRQF_SHARED | IRQF_DISABLED
+       .flags = IRQF_SHARED
 };
 
 /*
index ec0be14996a41cc20dc4ba1e489a61edbdf5acf2..494c9e7847aa173bd2ff7c395cb538385106ba9b 100644 (file)
@@ -68,7 +68,7 @@ static irqreturn_t a20r_interrupt(int irq, void *dev_id)
 
 static struct irqaction a20r_irqaction = {
        .handler        = a20r_interrupt,
-       .flags          = IRQF_DISABLED | IRQF_PERCPU | IRQF_TIMER,
+       .flags          = IRQF_PERCPU | IRQF_TIMER,
        .name           = "a20r-timer",
 };
 
index 85a87de17eb46f1197f92771a76b7812282aa4ff..682efb0c108d22576992c9f554653e9329916d3b 100644 (file)
@@ -262,7 +262,7 @@ txx9_i8259_irq_setup(int irq)
        int err;
 
        init_i8259_irqs();
-       err = request_irq(irq, &i8259_interrupt, IRQF_DISABLED|IRQF_SHARED,
+       err = request_irq(irq, &i8259_interrupt, IRQF_SHARED,
                          "cascade(i8259)", (void *)(long)irq);
        if (!err)
                printk(KERN_INFO "PCI-ISA bridge PIC (irq %d)\n", irq);