]> Pileus Git - ~andy/linux/commitdiff
staging: comedi: addi_apci_1516: cleanup apci1516_detach()
authorH Hartley Sweeten <hartleys@visionengravers.com>
Tue, 13 Nov 2012 20:46:19 +0000 (13:46 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 13 Nov 2012 23:12:54 +0000 (15:12 -0800)
This driver uses the comedi auto_config mechanism to attach to
the comedi subsystem. The dev->hw_dev is set by the core so
comedi_to_pci_dev() will always return a valid pcidev. Remove
the unnecessary test.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/comedi/drivers/addi_apci_1516.c

index 85ecd1a5229aa68bebbf632127b2dc859ad20c65..ac99774a7cb4ffeb86f46a69a46b9a2c75a53a09 100644 (file)
@@ -289,11 +289,9 @@ static void apci1516_detach(struct comedi_device *dev)
 {
        struct pci_dev *pcidev = comedi_to_pci_dev(dev);
 
-       if (dev->iobase)
+       if (dev->iobase) {
                apci1516_reset(dev);
-       if (pcidev) {
-               if (dev->iobase)
-                       comedi_pci_disable(pcidev);
+               comedi_pci_disable(pcidev);
        }
 }