]> Pileus Git - ~andy/linux/commitdiff
drm/radeon: update lockup tracking when scheduling in empty ring
authorJerome Glisse <jglisse@redhat.com>
Wed, 19 Jun 2013 14:02:28 +0000 (10:02 -0400)
committerAlex Deucher <alexander.deucher@amd.com>
Thu, 20 Jun 2013 18:45:08 +0000 (14:45 -0400)
There might be issue with lockup detection when scheduling on an
empty ring that have been sitting idle for a while. Thus update
the lockup tracking data when scheduling new work in an empty ring.

Signed-off-by: Jerome Glisse <jglisse@redhat.com>
Tested-by: Andy Lutomirski <luto@amacapital.net>
Cc: stable@vger.kernel.org
Reviewed-by: Christian König <christian.koenig@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/radeon/radeon_ring.c

index e17faa7cf732ee436e66f99fc0e3ac69c6798eab..82434018cbe81c3cd989de7f6586f88df57ddce1 100644 (file)
@@ -402,6 +402,13 @@ int radeon_ring_alloc(struct radeon_device *rdev, struct radeon_ring *ring, unsi
                return -ENOMEM;
        /* Align requested size with padding so unlock_commit can
         * pad safely */
+       radeon_ring_free_size(rdev, ring);
+       if (ring->ring_free_dw == (ring->ring_size / 4)) {
+               /* This is an empty ring update lockup info to avoid
+                * false positive.
+                */
+               radeon_ring_lockup_update(ring);
+       }
        ndw = (ndw + ring->align_mask) & ~ring->align_mask;
        while (ndw > (ring->ring_free_dw - 1)) {
                radeon_ring_free_size(rdev, ring);