]> Pileus Git - ~andy/linux/commitdiff
pinctrl: SPEAr: Update error check for unsigned variables
authorTushar Behera <tushar.behera@linaro.org>
Fri, 16 Nov 2012 06:50:39 +0000 (12:20 +0530)
committerLinus Walleij <linus.walleij@linaro.org>
Fri, 23 Nov 2012 07:33:41 +0000 (08:33 +0100)
Checking '< 0' for unsigned variables always returns false. For error
codes, use IS_ERR_VALUE() instead.

Signed-off-by: Tushar Behera <tushar.behera@linaro.org>
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/pinctrl/spear/pinctrl-plgpio.c

index 5aebbf780fb5dc05f38cf4f6ea314c050c4556c0..4c045053bbddd1e8a557861f7a73eb51ec64a97e 100644 (file)
@@ -284,7 +284,7 @@ static int plgpio_to_irq(struct gpio_chip *chip, unsigned offset)
 {
        struct plgpio *plgpio = container_of(chip, struct plgpio, chip);
 
-       if (plgpio->irq_base < 0)
+       if (IS_ERR_VALUE(plgpio->irq_base))
                return -EINVAL;
 
        return irq_find_mapping(plgpio->irq_domain, offset);