]> Pileus Git - ~andy/linux/commitdiff
sch_cbq: remove unnecessary null pointer check
authorYang Yingliang <yangyingliang@huawei.com>
Tue, 17 Dec 2013 07:29:17 +0000 (15:29 +0800)
committerDavid S. Miller <davem@davemloft.net>
Thu, 19 Dec 2013 20:06:55 +0000 (15:06 -0500)
It already has a NULL pointer check of rtab in qdisc_put_rtab().
Remove the check outside of qdisc_put_rtab().

Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/sched/sch_cbq.c

index d5a8a4b2454fa25a56a7b8637ed32dc615bb4edc..e25183333807143eafe86e4f0f55c94bcf8571b8 100644 (file)
@@ -1783,8 +1783,7 @@ cbq_change_class(struct Qdisc *sch, u32 classid, u32 parentid, struct nlattr **t
                                                    qdisc_root_sleeping_lock(sch),
                                                    tca[TCA_RATE]);
                        if (err) {
-                               if (rtab)
-                                       qdisc_put_rtab(rtab);
+                               qdisc_put_rtab(rtab);
                                return err;
                        }
                }