]> Pileus Git - ~andy/linux/commitdiff
sched: Update rq clock before migrating tasks out of dying CPU
authorFrederic Weisbecker <fweisbec@gmail.com>
Thu, 11 Apr 2013 23:50:58 +0000 (01:50 +0200)
committerIngo Molnar <mingo@kernel.org>
Tue, 28 May 2013 07:40:23 +0000 (09:40 +0200)
Because the sched_class::put_prev_task() callback of rt and fair
classes are referring to the rq clock to update their runtime
statistics. There is a missing rq clock update from the CPU
hotplug notifier's entry point of the scheduler.

Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Li Zhong <zhong@linux.vnet.ibm.com>
Cc: Steven Rostedt <rostedt@goodmis.org>
Cc: Paul Turner <pjt@google.com>
Cc: Mike Galbraith <efault@gmx.de>
Signed-off-by: Peter Zijlstra <peterz@infradead.org>
Link: http://lkml.kernel.org/r/1365724262-20142-2-git-send-email-fweisbec@gmail.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
kernel/sched/core.c

index 79e48e6a9385db7c516c2a3828835e4fa594749e..7bf0418dc60fa1f1559c049d125475ee39a65d7c 100644 (file)
@@ -4378,6 +4378,13 @@ static void migrate_tasks(unsigned int dead_cpu)
         */
        rq->stop = NULL;
 
+       /*
+        * put_prev_task() and pick_next_task() sched
+        * class method both need to have an up-to-date
+        * value of rq->clock[_task]
+        */
+       update_rq_clock(rq);
+
        for ( ; ; ) {
                /*
                 * There's this thread running, bail when that's the only