]> Pileus Git - ~andy/linux/commitdiff
perf ui gtk: Drop arg[cv] arguments from perf_gtk_setup_browser()
authorNamhyung Kim <namhyung.kim@lge.com>
Mon, 30 Apr 2012 04:55:06 +0000 (13:55 +0900)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Wed, 2 May 2012 19:17:25 +0000 (16:17 -0300)
As perf doesn't allow to specify gtk command-line option, drop the
arguments and pass NULL to gtk_init().

This makes the function easier to be called from setup_browser().

Signed-off-by: Namhyung Kim <namhyung.kim@lge.com>
Acked-by: Pekka Enberg <penberg@kernel.org>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Namhyung Kim <namhyung@gmail.com>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Pekka Enberg <penberg@kernel.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/r/1335761711-31403-3-git-send-email-namhyung.kim@lge.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/perf/builtin-report.c
tools/perf/ui/gtk/browser.c
tools/perf/util/cache.h

index cec2b8cee80cada5db9957d7355e708324cf83a2..2b20001848f5f4259610171ba9c3df8c0bbd086b 100644 (file)
@@ -678,7 +678,7 @@ int cmd_report(int argc, const char **argv, const char *prefix __used)
 
        if (strcmp(report.input_name, "-") != 0) {
                if (report.use_gtk)
-                       perf_gtk_setup_browser(argc, argv, true);
+                       perf_gtk_setup_browser(true);
                else
                        setup_browser(true);
        } else {
index 258352a2356c62b99948c45742febd8ba4896aa1..a1a83de3f4595026eb24fbc55bb16831ee9a6e51 100644 (file)
@@ -9,10 +9,9 @@
 
 #define MAX_COLUMNS                    32
 
-void perf_gtk_setup_browser(int argc, const char *argv[],
-                           bool fallback_to_pager __used)
+void perf_gtk_setup_browser(bool fallback_to_pager __used)
 {
-       gtk_init(&argc, (char ***)&argv);
+       gtk_init(NULL, NULL);
 }
 
 void perf_gtk_exit_browser(bool wait_for_ok __used)
index 8dd224df3e54ce4f88c8f09b852c07e93656442c..d22ca689fb1509c1b5268a439273844895261c23 100644 (file)
@@ -46,14 +46,14 @@ void exit_browser(bool wait_for_ok);
 #endif
 
 #ifdef NO_GTK2_SUPPORT
-static inline void perf_gtk_setup_browser(int argc __used, const char *argv[] __used, bool fallback_to_pager)
+static inline void perf_gtk_setup_browser(bool fallback_to_pager)
 {
        if (fallback_to_pager)
                setup_pager();
 }
 static inline void perf_gtk_exit_browser(bool wait_for_ok __used) {}
 #else
-void perf_gtk_setup_browser(int argc, const char *argv[], bool fallback_to_pager);
+void perf_gtk_setup_browser(bool fallback_to_pager);
 void perf_gtk_exit_browser(bool wait_for_ok);
 #endif