Rearrange the code a bit.

2006-04-12  Matthias Clasen  <mclasen@redhat.com>

	* gdk/x11/gdkkeys-x11.c (gdk_keymap_get_entries_for_keycode):
	Rearrange the code a bit.

diff --git a/ChangeLog b/ChangeLog
index 0287bd4f4731fe76f7ab98aa5726faa7f2136790..b21c2368811cda4cc361791a3bc24ef549ea8631 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,8 @@
 2006-04-12  Matthias Clasen  <mclasen@redhat.com>
 
+       * gdk/x11/gdkkeys-x11.c (gdk_keymap_get_entries_for_keycode): 
+       Rearrange the code a bit.
+
        * gtk/gtktextlayout.c (gtk_text_layout_validate_yrange): 
        Handle _gtk_text_line_get_data() returning NULL in all
        cases.  (Coverity)

diff --git a/ChangeLog.pre-2-10 b/ChangeLog.pre-2-10
index 0287bd4f4731fe76f7ab98aa5726faa7f2136790..b21c2368811cda4cc361791a3bc24ef549ea8631 100644 (file)
--- a/ChangeLog.pre-2-10
+++ b/ChangeLog.pre-2-10
@@ -1,5 +1,8 @@
 2006-04-12  Matthias Clasen  <mclasen@redhat.com>
 
+       * gdk/x11/gdkkeys-x11.c (gdk_keymap_get_entries_for_keycode): 
+       Rearrange the code a bit.
+
        * gtk/gtktextlayout.c (gtk_text_layout_validate_yrange): 
        Handle _gtk_text_line_get_data() returning NULL in all
        cases.  (Coverity)

diff --git a/gdk/x11/gdkkeys-x11.c b/gdk/x11/gdkkeys-x11.c
index 62742c1bc3dd6a34b18b7e3588dfc7d542605503..0fb4ae079feda7ac1ba1f3a51b4c138f7fad05bf 100644 (file)
--- a/gdk/x11/gdkkeys-x11.c
+++ b/gdk/x11/gdkkeys-x11.c
@@ -1015,37 +1015,21 @@ gdk_keymap_get_entries_for_keycode (GdkKeymap     *keymap,
           ++i;
         }
     }
-  
-  if ((key_array && key_array->len > 0) ||
-      (keyval_array && keyval_array->len > 0))
-    {
-      if (keys)
-        *keys = (GdkKeymapKey*) key_array->data;
 
-      if (keyvals)
-        *keyvals = (guint*) keyval_array->data;
+  *n_entries = 0;
 
-      if (key_array)
-        *n_entries = key_array->len;
-      else
-        *n_entries = keyval_array->len;
+  if (keys)
+    {
+      *n_entries = key_array->len;
+      *keys = (GdkKeymapKey*) g_array_free (key_array, FALSE);
     }
-  else
+  
+  if (keyvals)
     {
-      if (keys)
-        *keys = NULL;
-
-      if (keyvals)
-        *keyvals = NULL;
-      
-      *n_entries = 0;
+      *n_entries = keyval_array->len;
+      *keyvals = (guint*) g_array_free (keyval_array, FALSE);
     }
 
-  if (key_array)
-    g_array_free (key_array, key_array->len > 0 ? FALSE : TRUE);
-  if (keyval_array)
-    g_array_free (keyval_array, keyval_array->len > 0 ? FALSE : TRUE);
-
   return *n_entries > 0;
 }