]> Pileus Git - ~andy/linux/commitdiff
xfs: use xfs_ilock_attr_map_shared in xfs_attr_get
authorChristoph Hellwig <hch@infradead.org>
Fri, 6 Dec 2013 20:30:15 +0000 (12:30 -0800)
committerBen Myers <bpm@sgi.com>
Wed, 18 Dec 2013 22:07:09 +0000 (16:07 -0600)
We might not have read in the extent list at this point, so make sure we
take the ilock exclusively if we have to do so.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Dave Chinner <dchinner@redhat.com>
Signed-off-by: Ben Myers <bpm@sgi.com>
fs/xfs/xfs_attr.c

index b86127072ac3c2b9bd201b34cf208c3f1735cd68..01b6a0102fbdd4d153612740d95c4f00fda691f7 100644 (file)
@@ -164,6 +164,7 @@ xfs_attr_get(
 {
        int             error;
        struct xfs_name xname;
+       uint            lock_mode;
 
        XFS_STATS_INC(xs_attr_get);
 
@@ -174,9 +175,9 @@ xfs_attr_get(
        if (error)
                return error;
 
-       xfs_ilock(ip, XFS_ILOCK_SHARED);
+       lock_mode = xfs_ilock_attr_map_shared(ip);
        error = xfs_attr_get_int(ip, &xname, value, valuelenp, flags);
-       xfs_iunlock(ip, XFS_ILOCK_SHARED);
+       xfs_iunlock(ip, lock_mode);
        return(error);
 }