]> Pileus Git - ~andy/linux/commitdiff
powerpc: 52xx: provide a default in mpc52xx_irqhost_map()
authorSebastian Siewior <bigeasy@linutronix.de>
Mon, 12 Aug 2013 14:17:53 +0000 (16:17 +0200)
committerAnatolij Gustschin <agust@denx.de>
Mon, 12 Aug 2013 22:16:04 +0000 (00:16 +0200)
My gcc-4.3.5 fails to compile due to:

|cc1: warnings being treated as errors
|arch/powerpc/platforms/52xx/mpc52xx_pic.c: In function ‘mpc52xx_irqhost_map’:
|arch/powerpc/platforms/52xx/mpc52xx_pic.c:343: error: ‘irqchip’ may be used uninitialized in this function

since commit e34298c ("powerpc: 52xx: nop out unsupported critical
IRQs"). This warning is complete crap since only values 0…3 are possible
which are checked but gcc fails to understand that. I wouldn't care much
but since this is compiled with -Werror I made this patch.
While add it, I replaced the warning from l2irq to l1irq since this is
the number that is evaluated.

Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Signed-off-by: Anatolij Gustschin <agust@denx.de>
arch/powerpc/platforms/52xx/mpc52xx_pic.c

index b89ef65392dc229b4ec026e23ddd9c5228ed05f1..b69221ba07fd21868dc7c1892384969fb6c03d53 100644 (file)
@@ -373,8 +373,9 @@ static int mpc52xx_irqhost_map(struct irq_domain *h, unsigned int virq,
        case MPC52xx_IRQ_L1_PERP: irqchip = &mpc52xx_periph_irqchip; break;
        case MPC52xx_IRQ_L1_SDMA: irqchip = &mpc52xx_sdma_irqchip; break;
        case MPC52xx_IRQ_L1_CRIT:
+       default:
                pr_warn("%s: Critical IRQ #%d is unsupported! Nopping it.\n",
-                       __func__, l2irq);
+                       __func__, l1irq);
                irq_set_chip(virq, &no_irq_chip);
                return 0;
        }