]> Pileus Git - ~andy/linux/commitdiff
[SCSI] Revert "[SCSI] scsi_pm: set device runtime state before parent suspended"
authorAaron Lu <aaron.lu@intel.com>
Fri, 9 Nov 2012 07:27:52 +0000 (15:27 +0800)
committerJames Bottomley <JBottomley@Parallels.com>
Fri, 30 Nov 2012 09:24:43 +0000 (09:24 +0000)
This reverts commit 33a2285d96b5e7b9500612ec623bf4313397bb53.

With commit 88d26136a256576e444db312179e17af6dd0ea87 (PM: Prevent
runtime suspend during system resume), this patch is no longer needed.

Signed-off-by: Aaron Lu <aaron.lu@intel.com>
Acked-by: Alan Stern <stern@rowland.harvard.edu>
Acked-by: Rafael J. Wysocki <rjw@sisk.pl>
Signed-off-by: James Bottomley <JBottomley@Parallels.com>
drivers/scsi/scsi_pm.c

index dc0ad85853e20e30f90ae0045f20f789e4585599..d4201ded3b2203c0bd9cc17d8a26b528f5ccfc2c 100644 (file)
@@ -76,24 +76,23 @@ static int scsi_bus_resume_common(struct device *dev)
 {
        int err = 0;
 
-       /*
-        * Parent device may have runtime suspended as soon as
-        * it is woken up during the system resume.
-        *
-        * Resume it on behalf of child.
-        */
-       pm_runtime_get_sync(dev->parent);
-
-       if (scsi_is_sdev_device(dev))
+       if (scsi_is_sdev_device(dev)) {
+               /*
+                * Parent device may have runtime suspended as soon as
+                * it is woken up during the system resume.
+                *
+                * Resume it on behalf of child.
+                */
+               pm_runtime_get_sync(dev->parent);
                err = scsi_dev_type_resume(dev);
+               pm_runtime_put_sync(dev->parent);
+       }
+
        if (err == 0) {
                pm_runtime_disable(dev);
                pm_runtime_set_active(dev);
                pm_runtime_enable(dev);
        }
-
-       pm_runtime_put_sync(dev->parent);
-
        return err;
 }